Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(interview): Contact modal [4] #1157

Merged
merged 8 commits into from
Jan 23, 2025
Merged

feat(interview): Contact modal [4] #1157

merged 8 commits into from
Jan 23, 2025

Conversation

jochenklar
Copy link
Member

@jochenklar jochenklar commented Sep 27, 2024 •
edited
Loading

This PR adds the possibility to send questions though a contact form directly from the interview. It contains:

  • PROJECT_CONTACT and PROJECT_CONTACT_RECIPIENTS settings
  • different templates to customize emails and help texts
  • API endpoints to create the message and the subject, which then can be edited by the user, and to send it via email
  • fetchContact, sendContact, closeContact actions and a contactResolver for the Redux store
  • QuestionContact (the button) and Contact (the modal) components

Resolves: #502

Screenshot:

Screen Shot 2024-09-27 at 18 20 35

Screen Shot 2024-09-27 at 18 20 42

@jochenklar jochenklar added this to the RDMO 2.3.0 milestone Sep 27, 2024
@jochenklar jochenklar self-assigned this Sep 27, 2024
@jochenklar jochenklar changed the title Interview contact modal feature(interview): Contact modal [4] Nov 19, 2024
@jochenklar jochenklar changed the title feature(interview): Contact modal [4] feat(interview): Contact modal [4] Nov 19, 2024
@jochenklar jochenklar force-pushed the interview-copy-dataset branch from 01d9ef8 to b453485 Compare January 10, 2025 13:12
Base automatically changed from interview-copy-dataset to 2.3.0 January 17, 2025 14:54
@jochenklar jochenklar force-pushed the interview-contact-modal branch from eb9da41 to f199bc6 Compare January 17, 2025 15:13
@jochenklar
Copy link
Member Author

Ok, reabased and ready for review. I changed the questiomark to a speech-bubble but I am still not super happy with the icons. But I want to work on this when everything is merged.

image
image

@jochenklar jochenklar marked this pull request as ready for review January 17, 2025 15:21
@MyPyDavid MyPyDavid self-requested a review January 17, 2025 15:38
@jochenklar
Copy link
Member Author

Aaand found another unrelated with the end of the interview (b1a5da8)

MyPyDavid
MyPyDavid requested changes Jan 20, 2025
View reviewed changes
Copy link
Member

@MyPyDavid MyPyDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I think that the overall implementation is good. I have only few remarks about security aspects and performance optimization.

@jochenklar jochenklar merged commit ad6b993 into 2.3.0 Jan 23, 2025
19 checks passed
@jochenklar jochenklar deleted the interview-contact-modal branch January 23, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyPyDavid MyPyDavid MyPyDavid requested changes

Assignees

@jochenklar jochenklar

Labels
None yet
Projects
None yet
Milestone
RDMO 2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jochenklar @MyPyDavid