Add info to §1. Design elements and principles, that specification does not define any value validation #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elf-pavlik
approved these changes
Jan 23, 2019
rubensworks
approved these changes
Jan 23, 2019
vhf
reviewed
Jan 23, 2019
Co-Authored-By: k00ni <[email protected]>
|
I have committed your suggestion @vhf. |
bergos
approved these changes
Jan 23, 2019
|
Ping :) |
|
Due to conflicts I needed to pull your commits manually to master branch, thanks! |
|
No problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
For some people it may be obvious, but if you not that familiar with the rdfjs specification, you may wonder if an implementation should implement value validation or not.
@bergos stated it here and for me as an implementer its very important to know that.
What?
I added a point in
§1. Design elements and principles, which says that specification does not define any validation. If you want to change the text, feel free.Ref #130