Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support bake config with no-output targets for pre-pull #20

Merged
merged 3 commits into from
Jan 29, 2025
Merged

Support bake config with no-output targets for pre-pull #20

merged 3 commits into from
Jan 29, 2025

Conversation

rcwbr
Copy link
Owner

@rcwbr rcwbr commented Jan 28, 2025

Closes #19

What

Cleanly handle cases of empty outputs in the list of Bake targets.

Why

To support referencing all listed devcontainer targets in the default Bake group, even if not all have specified outputs

How

Conditionalize logic for extracting pre-pull images from target outputs

@rcwbr rcwbr added the bug Something isn't working label Jan 28, 2025
@rcwbr rcwbr self-assigned this Jan 28, 2025
@rcwbr rcwbr linked an issue Jan 28, 2025 that may be closed by this pull request
Fix handling of empty target outputs #19
Closed
@rcwbr rcwbr merged commit fdef416 into main Jan 29, 2025
4 checks passed
@rcwbr rcwbr deleted the 19-fix-handling-of-empty-target-outputs branch January 29, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rcwbr rcwbr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix handling of empty target outputs
1 participant
@rcwbr