Support background 256 colors. #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattgodbolt
added a commit
to compiler-explorer/compiler-explorer
that referenced
this pull request
Apr 1, 2021
* Rephrases a regex with a suggestion from @cpplearner to prevent catastrophic backtracking. * Cherry picks in some things from rburns/ansi-to-html#84 to support 256-colour better. * Adds some very simple tests. Fixes #1666. Fixes #2315
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current version does not handle 6x6x6 216 colors for background starting with "\e[48;5;".
I also need to handle both foreground and background setting in the same sequence, but it is beyond quick work.
This is my very first JavaScript program. Please discard and rewrite if not appropriate.