Skip to content

fix: persists datevalues in case of month and year change #2599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 11, 2025

Conversation

tewarig
Copy link
Contributor

@tewarig tewarig commented Apr 4, 2025

Description

fix: persists datevalues in case of month and year change

prev-

if you select any month , automatically date will reset to 1st of that month

Screen.Recording.2025-04-07.at.11.22.50.AM.mov

now -
it will keep the selected date value

Screen.Recording.2025-04-07.at.11.26.34.AM.mov

Changes

Additional Information

Component Checklist

  • Update Component Status Page
  • Perform Manual Testing in Other Browsers
  • Add KitchenSink Story
  • Add Interaction Tests (if applicable)
  • Add changeset

Copy link

changeset-bot bot commented Apr 4, 2025

🦋 Changeset detected

Latest commit: 2654392

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@razorpay/blade Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 4, 2025

✅ PR title follows Conventional Commits specification.

Copy link

codesandbox-ci bot commented Apr 4, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2654392:

Sandbox Source
razorpay/blade: basic Configuration

@rzpcibot
Copy link
Collaborator

rzpcibot commented Apr 4, 2025

Bundle Size Report

Updated Components
Status Component Base Size (kb) Current Size (kb) Diff
DatePicker 89.526 89.605 +0.079 KB
FilterChipDatePicker 89.521 89.600 +0.079 KB
getTableBodyStyles -0.046 -0.048 -0.002 KB

Generated by 🚫 dangerJS against 2654392

@tewarig tewarig changed the title fix: date range changing fix: persists datevalues in case of month and year change Apr 7, 2025
@tewarig tewarig marked this pull request as ready for review April 7, 2025 05:52
Copy link
Member

@saurabhdaware saurabhdaware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good. This is working with controlled and uncontrolled both right?

@tewarig
Copy link
Contributor Author

tewarig commented Apr 11, 2025

Nice! Looks good. This is working with controlled and uncontrolled both right?

yes
https://github.com/user-attachments/assets/5d8aeb4d-4113-4872-935c-637ab3dab6d7

@tewarig tewarig merged commit d929405 into master Apr 11, 2025
12 of 14 checks passed
@tewarig tewarig deleted the fix/x-date-picker-issues branch April 11, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants