Chore/serde restructure #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
arujit
commented
Nov 11, 2021
arujit
commented
- Comparing the producer-consumer API changes with the base code restructure branch.
…the working of it
…nced with streamconfigs
arujit
commented
Nov 11, 2021
| dependenciesCommonJar 'com.gojek:stencil:2.0.15' | ||
|
|
||
| testImplementation 'junit:junit:4.12' | ||
| testImplementation 'junit:junit:4.13' |
There was a problem hiding this comment.
This is to keep the Junit version same as the core.
arujit
commented
Nov 12, 2021
| @@ -60,9 +60,11 @@ dependencies { | |||
| compileOnly group: 'org.apache.flink', name: 'flink-connector-kafka_2.11', version: flinkVersion | |||
|
|
|||
| dependenciesCommonJar 'org.apache.flink:flink-metrics-dropwizard:' + flinkVersion | |||
| dependenciesCommonJar 'org.apache.flink:flink-json:' + flinkVersion | |||
There was a problem hiding this comment.
These two additions are related to protohandle classes which are migrated to common.
dagger-common/src/main/java/io/odpf/dagger/common/protohandler/TimestampProtoHandler.java
Show resolved
Hide resolved
dagger-common/src/test/java/io/odpf/dagger/common/protohandler/PrimitiveProtoHandlerTest.java
Show resolved
Hide resolved
| @@ -55,15 +55,27 @@ public ProtoSerializer(String keyProtoClassName, String messageProtoClassName, S | |||
| * @param outputTopic the output topic | |||
| */ | |||
| public ProtoSerializer(String keyProtoClassName, String messageProtoClassName, String[] columnNames, StencilClientOrchestrator stencilClientOrchestrator, String outputTopic) { | |||
| this(keyProtoClassName, messageProtoClassName, columnNames, stencilClientOrchestrator); | |||
There was a problem hiding this comment.
this was doing the same thing
dagger-core/src/main/java/io/odpf/dagger/core/metrics/reporters/ErrorReporterFactory.java
Show resolved
Hide resolved
arujit
added a commit
that referenced
this pull request
Feb 2, 2022
* refactor: move protohandler codebase to common and use new source sink APIs
Meghajit
pushed a commit
to Meghajit/dagger
that referenced
this pull request
Feb 9, 2022
* refactor: move protohandler codebase to common and use new source sink APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.