Upgrade glium example to winit 0.29 and glium 0.34
#86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
dependabot
bot
force-pushed
the
dependabot/cargo/glium-0.33.0
branch
from
72dfc70 to
9311ce6
Compare
|
I haven't been able to test this example because the JPEG decoder panics on data from my camera: |
MarijnS95
approved these changes
Dec 3, 2023
|
A newer version of glium exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
MarijnS95
changed the title
glium example to winit 0.29 and glium 0.34
|
@raymanfx can you check this? The current $ cargo r --example glium
Compiling v4l v0.14.0 (/newdata/Code/Rust/libv4l-rs)
Finished dev [unoptimized + debuginfo] target(s) in 1.55s
Running `target/debug/examples/glium`
Using device: /dev/video0
Active format:
width : 640
height : 480
fourcc : MJPG
field : progressive
stride : 0
size : 614400
colorspace : sRGB
quantization : default
transfer : sRGB transfer function
Active parameters:
capabilities : Capabilities(TIME_PER_FRAME)
modes : Modes(0x0)
interval : 1/5 [s]
interface 'wl_output' has no event 4
thread 'main' panicked at /home/marijn/.cargo/registry/src/index.crates.io-6f17d22bba15001f/winit-0.22.2/src/platform_impl/linux/wayland/event_loop.rs:405:10:
called `Result::unwrap()` on an `Err` value: Os { code: 0, kind: Uncategorized, message: "Success" }
stack backtrace:
0: rust_begin_unwind
at /rustc/7cf61ebde7b22796c69757901dd346d0fe70bd97/library/std/src/panicking.rs:647:5
1: core::panicking::panic_fmt
at /rustc/7cf61ebde7b22796c69757901dd346d0fe70bd97/library/core/src/panicking.rs:72:14
2: core::result::unwrap_failed
at /rustc/7cf61ebde7b22796c69757901dd346d0fe70bd97/library/core/src/result.rs:1649:5
3: core::result::Result<T,E>::unwrap
at /rustc/7cf61ebde7b22796c69757901dd346d0fe70bd97/library/core/src/result.rs:1073:23
4: winit::platform_impl::platform::wayland::event_loop::EventLoop<T>::new
at /home/marijn/.cargo/registry/src/index.crates.io-6f17d22bba15001f/winit-0.22.2/src/platform_impl/linux/wayland/event_loop.rs:337:19
5: winit::platform_impl::platform::EventLoop<T>::new_wayland_any_thread
at /home/marijn/.cargo/registry/src/index.crates.io-6f17d22bba15001f/winit-0.22.2/src/platform_impl/linux/mod.rs:579:9
6: winit::platform_impl::platform::EventLoop<T>::new_any_thread
at /home/marijn/.cargo/registry/src/index.crates.io-6f17d22bba15001f/winit-0.22.2/src/platform_impl/linux/mod.rs:555:33
7: winit::platform_impl::platform::EventLoop<T>::new
at /home/marijn/.cargo/registry/src/index.crates.io-6f17d22bba15001f/winit-0.22.2/src/platform_impl/linux/mod.rs:533:9
8: winit::event_loop::EventLoop<T>::with_user_event
at /home/marijn/.cargo/registry/src/index.crates.io-6f17d22bba15001f/winit-0.22.2/src/event_loop.rs:129:25
9: winit::event_loop::EventLoop<()>::new
at /home/marijn/.cargo/registry/src/index.crates.io-6f17d22bba15001f/winit-0.22.2/src/event_loop.rs:115:9
10: glium::main
at ./examples/glium.rs:57:22
11: core::ops::function::FnOnce::call_once
at /rustc/7cf61ebde7b22796c69757901dd346d0fe70bd97/library/core/src/ops/function.rs:250:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.But with this upgrade decoding fails, which is likely unrelated but I'd like to make sure that it runs first. |
Updates the requirements on [glium](https://github.com/glium/glium) to permit the latest version. - [Release notes](https://github.com/glium/glium/releases) - [Changelog](https://github.com/glium/glium/blob/master/CHANGELOG.md) - [Commits](glium/glium@v0.27.0...v0.33.0) --- updated-dependencies: - dependency-name: glium dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
`glutin` detached itself from `winit` by using `raw-window-handle` for window interop, and a minimal `glutin-winit` crate for lightweight window creation and event handling where necessary. This also makes the `glutin` crate more generic to use, for non-windowing GL cases.
MarijnS95
force-pushed
the
dependabot/cargo/glium-0.33.0
branch
from
ad5d176 to
d72437b
Compare
|
I forgot that I have an old and slow laptop, where this works but is quite terrible on the CPU. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the requirements on glium to permit the latest version.
Changelog
Sourced from glium's changelog.
... (truncated)
Commits
74a36a8Merge pull request #2082 from est31/master1676f0dRelease 0.33.0aa86599Changelog for 0.33d55006cMerge pull request #2068 from justincredible/cargo-testcd5da9fMerge pull request #2081 from joshlf/memoffset-0.9.03fbd243Update memoffset to 0.9.0deaa714Merge pull request #2079 from ben-sommer/patch-119f3e45fix: breaking typo000fefeMerge pull request #2078 from mykykh/patch-2ada9e24fix typo in tuto-01-getting-started.mdDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)