Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: Spelling Fix for Type::VbiCaputre #111

Merged
merged 1 commit into from
Oct 5, 2024
Merged

BREAKING CHANGE: Spelling Fix for Type::VbiCaputre #111

merged 1 commit into from
Oct 5, 2024

Conversation

onkoe
Copy link
Contributor

@onkoe onkoe commented Sep 5, 2024

This is a teeny tiny change to fix the spelling for the VbiCaputre variant in the buffer::Type enum. Note that a major version bump is required to avoid violating semantic versioning.

@onkoe
fix!(buffer): spelling for Type::VbiCaputre
113839e 
note that this is a breaking change and requires a major version bump!!!
MarijnS95
MarijnS95 approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@MarijnS95 MarijnS95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand those "semantic commit" prefixes, but the change itself is fine.

@raymanfx raymanfx merged commit 8837f57 into raymanfx:master Oct 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarijnS95 MarijnS95 MarijnS95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onkoe @MarijnS95 @raymanfx