Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add iMessage 2fa code extract shortcut extension #3210

Merged
merged 17 commits into from
Oct 14, 2022

Conversation

yuercl
Copy link
Contributor

@yuercl yuercl commented Oct 12, 2022

Description

iMessage Two Factor Authentication Code

Screencast

preview

Checklist

@raycastbot raycastbot added the new extension Label for PRs with new extensions label Oct 12, 2022
@raycastbot
Copy link
Collaborator

Congratulation on your new Raycast extension! 🚀

We will review it shortly. Once the PR is approved and merged, the extension will be available on the Store.

@tisfeng
Copy link
Contributor

tisfeng commented Oct 13, 2022

Good extension! I tried it, but it didn't seem to work, cannot get the messages on M1 mac, did I miss anything?

image

@pernielsentikaer
Copy link
Collaborator

Hi 👋

Thanks for the contribution 🔥

We do also have #1954 in the queue which looks more or less like the same thing?

@pernielsentikaer pernielsentikaer self-assigned this Oct 13, 2022
@yuercl
Copy link
Contributor Author

yuercl commented Oct 13, 2022

Good extension! I tried it, but it didn't seem to work, cannot get the messages on M1 mac, did I miss anything?

image

This tool can search within last 24 hours ago messages which may contain two factor auth code possibly.
只搜索了最近24小时的短信 @tisfeng

- add default view if no code found
@tisfeng
Copy link
Contributor

tisfeng commented Oct 13, 2022

@yuercl I know, and I confirm that I have received SMS messages on my Mac within 24 hours. I checked using the console log, it seems that it can't read the SMS.

I don't know much about the development environment of Apple desktop, but I am curious as to how the program reads the user's text messages without the user's knowledge and authorization to do so. This is inconsistent with what I understand to be Apple's system privacy policy.

My device: Apple M1 Pro, OS: 13.0 Beta(22A5373b)

image

@tisfeng
Copy link
Contributor

tisfeng commented Oct 13, 2022

Ok, I just pulled your latest code and it works as expected now. 🎉

@pernielsentikaer
Copy link
Collaborator

Could it be nice with a preference to select how long timespan you'll see 2FA codes, or is that irrelevant?

@yuercl
Copy link
Contributor Author

yuercl commented Oct 13, 2022

Could it be nice with a preference to select how long timespan you'll see 2FA codes, or is that irrelevant?

  1. support extract 2fa code.
  2. support all messages display and filter search.
  3. make 「extract 2FA code」 to Action, not a main function.

@tisfeng
Copy link
Contributor

tisfeng commented Oct 13, 2022

I used it and feel good. I have a suggestion, could you add an action Copy to Clipboard on the main page if the 2fa code is detected? so that the user can easily copy it to the clipboard after receiving the code, instead of going to the sub-page and then get it.

Also, it would be better to display the SMS details with Detail components, currently one line list may not be able to display the full SMS content.

iShot_2022-10-13_17 53 30

- add preview content in list
- new ui
@yuercl
Copy link
Contributor Author

yuercl commented Oct 14, 2022

preview_2facode

submit a new version @tisfeng

@tisfeng
Copy link
Contributor

tisfeng commented Oct 14, 2022

Great, this extension will help many users who are used to receiving 2FA code on Mac, I'm looking forward to seeing it in the store!

@yuercl
Copy link
Contributor Author

yuercl commented Oct 14, 2022

Could it be nice with a preference to select how long timespan you'll see 2FA codes, or is that irrelevant?

  • latest code has support preference search time gap.
  • add new filter for search 2fa code or not.
  • quick link to copy 2fa code in main list.
  • improve ui that displays entire message content to list detail component.
    @pernielsentikaer

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

@pernielsentikaer pernielsentikaer merged commit 709a9e3 into raycast:main Oct 14, 2022
@raycastbot
Copy link
Collaborator

Published to the Raycast Store:
https://raycast.com/yuercl/imessage-2fa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new extension Label for PRs with new extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants