Update bitwarden extension #17153

marinsokol · 2025-02-18T16:34:44Z

Description

This MR introduces options to search vault using username or url.

By default, search using username or url is disabled. To enable, options need to be activated in Search Vault command preferences.

Inspired by issues 16419 and 16965

Screencast

Checklist

I read the extension guidelines
I read the documentation about publishing
I ran npm run build and tested this distribution build in Raycast
I checked that files in the assets folder are used by the extension itself
I checked that assets used by the README are placed outside of the metadata folder

- minor improvement - update changelog - update changelog - add options to search by url or username - Initial commit

raycastbot · 2025-02-18T16:35:03Z

Thank you for your contribution! 🎉

🔔 @jomifepe @daniel-stoneuk @andreaselia @pernielsentikaer @eth-p @YamenSharaf @undefinedzack @anirudhganwal06 @ivaarsson @gasparhabif you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

Due to our current reduced availability, the initial review may take up to 10-15 business days

jomifepe · 2025-02-20T00:10:40Z

Hey! Thanks for contributing, but isn't this already implemented? The username and URL are added to the search keywords. Is it not working for you?

marinsokol · 2025-02-20T10:13:51Z

sorry, i did not notice that username is working, but url is not working for me.

jomifepe · 2025-02-20T14:21:36Z

sorry, i did not notice that username is working, but url is not working for me.

I just saw that the built-in List search is limited, and is not capable of fully fuzzy searching whole keywords, so this contribution is indeed needed.

jomifepe

Thanks again for contributing, this is a good addition 🚀

I left some suggestions, tell me what you think!

jomifepe · 2025-02-20T14:33:16Z

extensions/bitwarden/src/context/search.tsx

+export const useVaultWithSearch = () => {
+  const { items, folders, isLoading, isEmpty } = useVaultContext();
+  const [searchText, setSearchText] = useState("");
+  const { shouldSearchUsername, shouldSearchUrl } = getPreferenceValues();
+
+  const searchedItems = useMemo(() => {
+    const searchTxt = searchText.toLowerCase().trim();
+    return searchTxt
+      ? items.filter((item) => {
+          const matchesName = item.name.toLowerCase().includes(searchTxt);
+          const matchesUsername =
+            shouldSearchUsername && item.login?.username ? item.login.username.includes(searchTxt) : false;
+          const urls = shouldSearchUrl && item.login?.uris ? item.login.uris.map((uri) => uri.uri)?.join(" ") : null;
+          const matchesUrl = shouldSearchUrl && urls?.length ? urls.includes(searchTxt) : false;
+
+          return matchesName || matchesUsername || matchesUrl;
+        })
+      : items;
+  }, [items, searchText, shouldSearchUsername, shouldSearchUrl]);
+
+  return { items: searchedItems, folders, isLoading, isEmpty, setSearchText };
+};


💡 Personally, I would not move the vault context here, and only use the hook for the search/filtering logic. This also replaces the extractKeywords function, so it can live in that file and reuse part of its logic.

Something like this:

// utils/search.ts function hasValue(value: string | null | undefined): value is string { return !!(value && value !== SENSITIVE_VALUE_PLACEHOLDER); } function searchItems(items: Item[], searchText: string): Item[] { const searchTextLower = searchText.toLowerCase().trim(); if (!searchTextLower) return items; return items.filter((item) => { const searchableProps = new Set([item.name, ITEM_TYPE_TO_LABEL[item.type]]); switch (item.type) { case ItemType.LOGIN: { const { username, uris } = item.login ?? {}; if (hasValue(username)) searchableProps.add(username); if (uris?.length) uris.forEach(({ uri }) => hasValue(uri) && searchableProps.add(uri)); break; } case ItemType.CARD: { const { brand, number } = item.card ?? {}; if (hasValue(brand)) searchableProps.add(brand); if (hasValue(number)) searchableProps.add(number); break; } } return Array.from(searchableProps).some((p) => p.toLowerCase().includes(searchTextLower)); }); } export function useVaultSearch(items: Item[]) { const [searchText, setSearchText] = useState(""); const filteredItems = useMemo(() => searchItems(items, searchText), [items, searchText]); return { setSearchText, filteredItems }; }

yep, this makes sense. Will update MR

jomifepe · 2025-02-20T14:41:52Z

extensions/bitwarden/package.json

+        {
+          "name": "shouldSearchUsername",
+          "type": "checkbox",
+          "required": false,
+          "default": false,
+          "title": "Include username when searching",
+          "label": "Search by Username",
+          "description": "By default search uses only title, this will also include username."
+        },
+        {
+          "name": "shouldSearchUrl",
+          "type": "checkbox",
+          "required": false,
+          "default": false,
+          "title": "Include url when searching",
+          "label": "Search by URL",
+          "description": "By default search uses only title, this will also include url."
+        },


💡 I saw that this was mentioned in one of the issue, but personally I don't think we need to have an option for this, it could simply be the default behavior. WDYT?

Yeah, I was thinking about this. I added this as a safety barrier, so users do not get more results unexpectedly. I am more for removing it. If you agree, lets simplify this.

Yeah let's keep it simple for now.

pernielsentikaer · 2025-02-21T09:53:37Z

Testing a AI review bot too, let's see what it says

greptile-apps

PR Summary

Added search functionality to the Bitwarden extension, allowing users to search vault items by username and URL in addition to the default title search.

Added new useVaultWithSearch hook in /extensions/bitwarden/src/context/search.tsx implementing case-insensitive search across name, username, and URL fields
Added two new preferences in package.json for enabling username and URL search (disabled by default)
Updated CHANGELOG.md with new feature entry using {PR_MERGE_DATE} placeholder
Added new contributor 'marinsokol' to package.json

_{💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!}

_{4 file(s) reviewed, 4 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

extensions/bitwarden/package.json

extensions/bitwarden/src/context/search.tsx

LitoMore · 2025-02-21T16:09:01Z

You can consider using https://npmjs.com/fast-fuzzy for a better search experience.

marinsokol · 2025-02-24T21:56:36Z

You can consider using https://npmjs.com/fast-fuzzy for a better search experience.

good idea, thanks. I updated MR with all suggestions and it is ready for next review.

pernielsentikaer · 2025-02-25T11:48:56Z

@LitoMore does this work as you proprosed now?

Is this ready for a final review @marinsokol

LitoMore · 2025-02-25T12:15:12Z

Hi @marinsokol, here is a simpler code of fast-fuzzy for you:

https://github.com/LitoMore/simple-icons-figma/blob/f710a5f1d1ecf30fefde51c20187dd47c3a0053f/source/components/icons.tsx#L26-L39

You only need the Searcher to create a search instance. You can also use a useMemo to improve its performance:

import useMemo from 'react';
import {Searcher} from 'fast-fuzzy';

const searcher = useMemo(new Searcher(icons, {
	keySelector(icon) {
		return [
			icon.title,
			icon.description,
			icon.fooIsArrayOfString,
			icon.moreContentsForSearching,
		]
			.flat()
			.filter(Boolean) as string[];
	},
}), [icons]);

const searchResult = searchString ? searcher.search(searchString) : icons;

But it's fine to keep your current implementation. That's up to you.

marinsokol · 2025-02-25T15:16:36Z

Hi @marinsokol, here is a simpler code of fast-fuzzy for you:

https://github.com/LitoMore/simple-icons-figma/blob/f710a5f1d1ecf30fefde51c20187dd47c3a0053f/source/components/icons.tsx#L26-L39

You only need the Searcher to create a search instance. You can also use a useMemo to improve its performance:
import useMemo from 'react';
import {Searcher} from 'fast-fuzzy';

const searcher = useMemo(new Searcher(icons, {
	keySelector(icon) {
		return [
			icon.title,
			icon.description,
			icon.fooIsArrayOfString,
			icon.moreContentsForSearching,
		]
			.flat()
			.filter(Boolean) as string[];
	},
}), [icons]);

const searchResult = searchString ? searcher.search(searchString) : icons;
But it's fine to keep your current implementation. That's up to you.

good idea, code looks much cleaner now that i updated MR

Update bitwarden extension

2d0992c

- minor improvement - update changelog - update changelog - add options to search by url or username - Initial commit

marinsokol requested a review from pernielsentikaer as a code owner February 18, 2025 16:34

raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: bitwarden Issues related to the bitwarden extension labels Feb 18, 2025

jomifepe reviewed Feb 20, 2025

View reviewed changes

pernielsentikaer self-assigned this Feb 21, 2025

greptile-apps bot reviewed Feb 21, 2025

View reviewed changes

marinsokol added 3 commits February 24, 2025 18:13

Merge branch 'raycast:main' into ext/bitwarden

685b873

implement fuzzy search on vault

37ce082

update CHANGELOG

15bf079

update fuzzy search

7c7c23e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update bitwarden extension #17153

Update bitwarden extension #17153

marinsokol commented Feb 18, 2025 •

edited

Loading

raycastbot commented Feb 18, 2025 •

edited

Loading

jomifepe commented Feb 20, 2025 •

edited

Loading

marinsokol commented Feb 20, 2025

jomifepe commented Feb 20, 2025

jomifepe left a comment

jomifepe Feb 20, 2025 •

edited

Loading

marinsokol Feb 21, 2025

jomifepe Feb 20, 2025 •

edited

Loading

marinsokol Feb 21, 2025

jomifepe Feb 21, 2025

pernielsentikaer commented Feb 21, 2025

greptile-apps bot left a comment

LitoMore commented Feb 21, 2025

marinsokol commented Feb 24, 2025

pernielsentikaer commented Feb 25, 2025

LitoMore commented Feb 25, 2025

marinsokol commented Feb 25, 2025

Update bitwarden extension #17153

Are you sure you want to change the base?

Update bitwarden extension #17153

Conversation

marinsokol commented Feb 18, 2025 • edited Loading

Description

Screencast

Checklist

raycastbot commented Feb 18, 2025 • edited Loading

jomifepe commented Feb 20, 2025 • edited Loading

marinsokol commented Feb 20, 2025

jomifepe commented Feb 20, 2025

jomifepe left a comment

Choose a reason for hiding this comment

jomifepe Feb 20, 2025 • edited Loading

Choose a reason for hiding this comment

marinsokol Feb 21, 2025

Choose a reason for hiding this comment

jomifepe Feb 20, 2025 • edited Loading

Choose a reason for hiding this comment

marinsokol Feb 21, 2025

Choose a reason for hiding this comment

jomifepe Feb 21, 2025

Choose a reason for hiding this comment

pernielsentikaer commented Feb 21, 2025

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

LitoMore commented Feb 21, 2025

marinsokol commented Feb 24, 2025

pernielsentikaer commented Feb 25, 2025

LitoMore commented Feb 25, 2025

marinsokol commented Feb 25, 2025

marinsokol commented Feb 18, 2025 •

edited

Loading

raycastbot commented Feb 18, 2025 •

edited

Loading

jomifepe commented Feb 20, 2025 •

edited

Loading

jomifepe Feb 20, 2025 •

edited

Loading

jomifepe Feb 20, 2025 •

edited

Loading