Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add neurooo-translate extension #16949

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

depsimon
Copy link

@depsimon depsimon commented Feb 10, 2025

Description

Screencast

Checklist

- [Neurooo Translate] Fix lint
- [Neurooo Translate] Remove unused component
- [Neurooo Translate] Update packages
- [Neurooo Translate]: Adapt to new API docs
- Cleanup
- [Neurooo Translate] Update endpoint
- [Neurooo Translate] Handle errors
- [Neurooo Translate] Remove unused commands and improve translation
- [New Extension] Neurooo Translate
- Initial commit
@raycastbot raycastbot added the new extension Label for PRs with new extensions label Feb 10, 2025
@raycastbot
Copy link
Collaborator

raycastbot commented Feb 10, 2025

Congratulations on your new Raycast extension! 🚀

Due to our current reduced availability, the initial review may take up to 10-15 business days

Once the PR is approved and merged, the extension will be available on our Store.

@raycastbot
Copy link
Collaborator

This pull request has been automatically marked as stale because it did not have any recent activity.

It will be closed if no further activity occurs in the next 7 days to keep our backlog clean 😊

@raycastbot raycastbot added the status: stalled Stalled due inactivity label Feb 24, 2025
@depsimon
Copy link
Author

Up

@raycastbot raycastbot removed the status: stalled Stalled due inactivity label Feb 24, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Added a new Neurooo Translate extension that provides smart translation functionality with support for multiple languages and tones.

  • The CHANGELOG.md uses a hardcoded date (2025-02-10) instead of {PR_MERGE_DATE} which would be automatically replaced with the actual merge date
  • The translateText function in src/translate.tsx should be wrapped in a try-catch block for proper error handling
  • Consider using showFailureToast from @raycast/utils instead of manually creating error toasts
  • Add a metadata folder with screenshots since this is a new extension with a view command
  • The language code for German is incorrectly set as "ge" in languages.ts (should be "de")
  • Consider adding a subtitle to the command with the service name ("Neurooo") for better identification

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

11 file(s) reviewed, 7 comment(s)
Edit PR Review Bot Settings | Greptile

@pernielsentikaer pernielsentikaer self-assigned this Feb 25, 2025
Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you look into the review points 🙂

Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.

@pernielsentikaer pernielsentikaer self-requested a review February 25, 2025 13:56
@depsimon
Copy link
Author

@greptileai can you review again?

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

This PR adds a new Neurooo Translate extension that provides translation functionality with language detection and tone selection capabilities.

  • Fixed CHANGELOG.md to use {PR_MERGE_DATE} placeholder instead of hardcoded date
  • The translateText function in src/translate.tsx now properly handles errors with early returns when receiving error responses
  • English language codes in languages.ts appear to be swapped - en-GB is labeled as "English (US)" and en-US is labeled as "English (GB)"
  • Added subtitle "Neurooo" to the command in package.json for better identification
  • The API request in translate.tsx should be wrapped in a try-catch block for better error handling

4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new extension Label for PRs with new extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants