Skip to content

Conversation

aslonnie
Copy link
Collaborator

@aslonnie aslonnie commented Sep 4, 2025

disable all java tests. ray java not supported on apple silicon yet.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Buildkite CI configuration to run the C++ and Java tests on a macos-arm64 instance. While this is a good step towards supporting Apple Silicon, the associated test script ci/ray_ci/macos/macos_ci.sh contains a hardcoded JAVA_HOME path. This path may not be valid on the new arm64 architecture, which could lead to build failures. I've added a comment highlighting this risk and suggesting a more robust way to set the Java home directory.

@ray-gardener ray-gardener bot added the devprod label Sep 4, 2025
@aslonnie
Copy link
Collaborator Author

aslonnie commented Sep 4, 2025

Copy link

This pull request has been automatically marked as stale because it has not had
any activity for 14 days. It will be closed in another 14 days if no further activity occurs.
Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@github-actions github-actions bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Sep 19, 2025
@aslonnie aslonnie removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Sep 21, 2025
@aslonnie aslonnie force-pushed the lonnie-250903-macosarm64 branch from 8efcac3 to 57a6f00 Compare October 1, 2025 05:02
@aslonnie aslonnie requested review from a team, SongGuyang, kfstorm and raulchen as code owners October 1, 2025 05:02
cursor[bot]

This comment was marked as outdated.

@aslonnie aslonnie force-pushed the lonnie-250903-macosarm64 branch 2 times, most recently from bf83e37 to de604c2 Compare October 1, 2025 05:40
@aslonnie
Copy link
Collaborator Author

aslonnie commented Oct 1, 2025

new attempt: https://buildkite.com/ray-project/postmerge-macos/builds/8388#_

just disable java.. it does not work anyways. and no one should be using new ray version with intel silicon macos any more.

@aslonnie aslonnie force-pushed the lonnie-250903-macosarm64 branch from de604c2 to 4e88146 Compare October 1, 2025 07:24
@aslonnie aslonnie force-pushed the lonnie-250903-macosarm64 branch from 4e88146 to ac421ec Compare October 1, 2025 18:14
@aslonnie aslonnie force-pushed the lonnie-250903-macosarm64 branch from ac421ec to e8a826a Compare October 1, 2025 20:35
Copy link

This pull request has been automatically marked as stale because it has not had
any activity for 14 days. It will be closed in another 14 days if no further activity occurs.
Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@github-actions github-actions bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Oct 16, 2025
@aslonnie aslonnie changed the title try run macos test on arm64 once more.. [macos] run macos cpp tests on apple silicon Oct 16, 2025
@aslonnie aslonnie removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Oct 16, 2025
@aslonnie
Copy link
Collaborator Author

cursor[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant