-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[macos] run macos cpp tests on apple silicon #56222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Buildkite CI configuration to run the C++ and Java tests on a macos-arm64
instance. While this is a good step towards supporting Apple Silicon, the associated test script ci/ray_ci/macos/macos_ci.sh
contains a hardcoded JAVA_HOME
path. This path may not be valid on the new arm64 architecture, which could lead to build failures. I've added a comment highlighting this risk and suggesting a more robust way to set the Java home directory.
This pull request has been automatically marked as stale because it has not had You can always ask for help on our discussion forum or Ray's public slack channel. If you'd like to keep this open, just leave any comment, and the stale label will be removed. |
8efcac3
to
57a6f00
Compare
bf83e37
to
de604c2
Compare
new attempt: https://buildkite.com/ray-project/postmerge-macos/builds/8388#_ just disable java.. it does not work anyways. and no one should be using new ray version with intel silicon macos any more. |
de604c2
to
4e88146
Compare
Signed-off-by: Lonnie Liu <[email protected]>
4e88146
to
ac421ec
Compare
Signed-off-by: Lonnie Liu <[email protected]>
ac421ec
to
e8a826a
Compare
This pull request has been automatically marked as stale because it has not had You can always ask for help on our discussion forum or Ray's public slack channel. If you'd like to keep this open, just leave any comment, and the stale label will be removed. |
Signed-off-by: Lonnie Liu <[email protected]>
Signed-off-by: Lonnie Liu <[email protected]>
disable all java tests. ray java not supported on apple silicon yet.