Skip to content

Remove Placement Group on Train Run Abort #56011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 3, 2025
Merged

Remove Placement Group on Train Run Abort #56011

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8f3106f
shutdown worker group state on abort
JasonLi1909 Aug 27, 2025
02999e3
Update python/ray/train/v2/_internal/execution/worker_group/worker_gr…
JasonLi1909 Aug 27, 2025
7b7d571
updated todo comments
JasonLi1909 Aug 28, 2025
667c772
extended test_worker_group_abort to test for worker group state shutdown
JasonLi1909 Aug 29, 2025
426e525
Merge branch 'master' into placement-group-cleanup-on-train-abort
JasonLi1909 Aug 29, 2025
ff2c288
testing
JasonLi1909 Sep 2, 2025
bcc41c0
removed shutdown on abort test
JasonLi1909 Sep 2, 2025
7b8c3e4
updated abort to fix cleanup
JasonLi1909 Sep 3, 2025
59ccdfa
Merge branch 'master' into placement-group-cleanup-on-train-abort
JasonLi1909 Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion python/ray/train/v2/_internal/execution/worker_group/worker_group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,11 +476,14 @@ def abort(self):
"""Abort the worker group."""
# TODO: consider shutting down the workers in the future.
# We don't do this for now due to this risk of hanging e.g. when calling
# `destroy_process_group` on an active group.
# `destroy_process_group` on an active group. A solution is to use a timeout
Copy link
Contributor

@TimothySeah TimothySeah Aug 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait I think consider shutting down the workers in the future. is no longer applicable because worker_group_state.shutdown does do that right? Do we need to fix the destroy_process_group on an active group issue in this PR too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks for the catch! I will remove the comment regarding the worker shutdown. As for the destroy_process_goup on an active group that is not triggered unless we also perform the before_worker_group_abort callbacks so it will not be included in this PR

# in TorchConfig.on_shutdown in case of a hang.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"TODO: add shutdown callback hooks"

self._assert_active()
for callback in self._callbacks:
callback.before_worker_group_abort(self._worker_group_context)

self._worker_group_state.shutdown()

#####################################################################################
# Polling Worker Group
#####################################################################################
Expand Down