Skip to content

Conversation

mattip
Copy link
Contributor

@mattip mattip commented Mar 28, 2025

Replaces #51673 since buildkite CI somehow cannot find the git commits there and a previous attempt to update protobuf in #48724

Why are these changes needed?

The file upb/message/internal/message.c used by upb, which is used by protobuf, is not compatible with latest windows SDKs, see the visual studio discussion. Unfortunately in the current version of protobuf, upb is a transient dependency which makes patching it very difficult. Over at conda-forge we updated to grpc1.67 and protobuf 28.2. The newer version vendors upb, which gives us a cleaner path to patching the file.

Basically this PR is a backport of the work done in conda-forge to adapt to later windows SDK versions, and also helps with the transition to Visual Studio 2022 (currently the CI build uses Visual Studio 2019).

Related issue number

This is related to internal work done to update the CI build to use a windows 11 image.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@mattip mattip requested a review from a team as a code owner March 28, 2025 06:17
@mattip
Copy link
Contributor Author

mattip commented Mar 28, 2025

No, this didn't clear the git checkout error. It seems rebasing the previous PR did however clear the git error. Who knows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants