Skip to content

Commit

Permalink
cherrypick #48563 and #48527 (#48574)
Browse files Browse the repository at this point in the history
fixes rllib release tests and mac debugger test

Signed-off-by: Lonnie Liu <[email protected]>
  • Loading branch information
aslonnie authored Nov 5, 2024
1 parent 06e23b0 commit 5a6c335
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 3 deletions.
9 changes: 9 additions & 0 deletions python/ray/tests/test_ray_debugger.py
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,15 @@ def fact(n):

result = fact.remote(5)

wait_for_condition(
lambda: len(
ray.experimental.internal_kv._internal_kv_list(
"RAY_PDB_", namespace=ray_constants.KV_NAMESPACE_PDB
)
)
> 0
)

p = pexpect.spawn("ray debug")
p.expect("Enter breakpoint index or press enter to refresh: ")
p.sendline("0")
Expand Down
10 changes: 7 additions & 3 deletions release/ml_user_tests/tune_rllib/run_connect_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,20 @@ def run(smoke_test=False, storage_path: str = None):

config = (
APPOConfig()
.api_stack(
enable_rl_module_and_learner=False,
enable_env_runner_and_connector_v2=False,
)
.environment("ale_py:ALE/Pong-v5", clip_rewards=True)
.framework(tune.grid_search(["tf", "torch"]))
.rollouts(
rollout_fragment_length=50,
num_rollout_workers=num_workers,
num_envs_per_worker=1,
num_env_runners=num_workers,
num_envs_per_env_runner=1,
)
.training(
train_batch_size=750,
num_sgd_iter=2,
num_epochs=2,
vf_loss_coeff=1.0,
clip_param=0.3,
grad_clip=10,
Expand Down

0 comments on commit 5a6c335

Please sign in to comment.