Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/update_handler: Allow overriding the configured casync store path #630

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kevinior
Copy link

@kevinior kevinior commented Sep 7, 2020

This commit adds a command-line argument --store-path to the install
command and the InstallBundle() D-Bus method.

The argument overrides the casync store path that is configured (or the
default based on the bundle filename if not configured).

Fixes #606

Signed-off-by: Kevin O'Rourke [email protected]

This commit adds a command-line argument `--store-path` to the install
command and the `InstallBundle()` D-Bus method.

The argument overrides the casync store path that is configured (or the
default based on the bundle filename if not configured).

Signed-off-by: Kevin O'Rourke <[email protected]>
@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #630 into master will increase coverage by 0.00%.
The diff coverage is 69.23%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #630   +/-   ##
=======================================
  Coverage   73.92%   73.92%           
=======================================
  Files          25       25           
  Lines        7356     7368   +12     
=======================================
+ Hits         5438     5447    +9     
- Misses       1918     1921    +3     
Impacted Files Coverage Δ
src/install.c 81.45% <50.00%> (-0.21%) ⬇️
src/service.c 76.27% <50.00%> (-0.18%) ⬇️
src/main.c 75.90% <66.66%> (-0.03%) ⬇️
src/bundle.c 70.00% <100.00%> (+0.28%) ⬆️
src/context.c 77.88% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24974e2...324c7c8. Read the comment docs.

@kevinior kevinior changed the title Allow overriding the configured casync store path src/update_handler: Allow overriding the configured casync store path Sep 10, 2020
@ejoerns ejoerns added the enhancement Adds new functionality or enhanced handling to RAUC label Oct 24, 2020
@ejoerns ejoerns self-assigned this Nov 30, 2020
@jluebbe
Copy link
Member

jluebbe commented Apr 22, 2022

@RyuzakiKK Is something like this also relevant for you? If so, we should perhaps pick this up again, with some minor changes (i.e. casync-store-path instead of store-path).

@jluebbe jluebbe added this to the Unplanned milestone Apr 22, 2022
@RyuzakiKK
Copy link
Contributor

@RyuzakiKK Is something like this also relevant for you? If so, we should perhaps pick this up again, with some minor changes (i.e. casync-store-path instead of store-path).

No, at the moment it's not because we always place the store next to the rauc bundle file URL.

Anyway, that option would probably make rauc more flexible.

@ejoerns ejoerns added the casync casync-related label Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
casync casync-related enhancement Adds new functionality or enhanced handling to RAUC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

casync chunk store URL handling improvements
4 participants