use a temporary workdir during bundle creation #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jluebbe
added
the
enhancement
ejoerns
reviewed
May 23, 2024
There was a problem hiding this comment.
I really like the idea in general, since it also solves current confusion we have by modifying the manifest in-place.
My biggest concern is to break a number of use-cases we don't know about, yet.
Would it be an option to loudly warn and fall back to the 'contentdir' for a transition phase?
We should maybe also instruct users via error messages to contact us, since probably not all users of bundle creation will be familiar with looking into the code/commit message..
jluebbe
force-pushed
the
workdir
branch
2 times, most recently
from
646dcd5
to
57fb8aa
Compare
|
I've added a FAQ entry as discussed internally. |
ejoerns
requested changes
May 23, 2024
Currently, we modify and add files in the input directory. While this isn't much of a problem now, we will need to delete converted files when converting tar archives to file trees in the context of artifacts. That would require the user to always re-create the bundle input directory after running 'rauc bundle', which would be annoying. It seems the simplest way is to hard-link all files from the input dir to a .rauc-workdir subdirectory. This way, we don't need actually copy any data and keep the rest of the bundle creation code unaffected. For simplicity, we abort on anything in the input dir which is not a regular file. If someone relies on the old (undocumented) behavior of including directories and symlinks in the bundle, please contact us. Signed-off-by: Jan Luebbe <[email protected]>
As we no longer modify the manifest in place, we can drop the generated information, which would otherwise cause git to report modifications after running the tests. Signed-off-by: Jan Luebbe <[email protected]>
ejoerns
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we modify and add files in the input directory. While this
isn't much of a problem now, we will need to delete converted files when
converting tar archives to file trees in the context of artifacts. That
would require the user to always re-create the bundle input directory
after running 'rauc bundle', which would be annoying.
It seems the simplest way is to hard-link all files from the input dir
to a .rauc-workdir subdirectory. This way, we don't need actually copy
any data and keep the rest of the bundle creation code unaffected.
For simplicity, we abort on anything in the input dir which is not a
regular file. If someone relies on the old (undocumented) behaviour of
including directories and symlinks in the bundle, please contact us.