Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronize Damage Feature #8305

Merged
merged 20 commits into from
May 25, 2024
Merged

Synchronize Damage Feature #8305

merged 20 commits into from
May 25, 2024

Commits on May 2, 2024

  1. Adds ClientAttackMotion to mob database 

    * Fixes #259.
* Initial attempt to resolve position lag with normal attacks against monsters.
    @aleos89
    aleos89 committed May 2, 2024
    Configuration menu
    Copy the full SHA
    059f6e0 View commit details
    Browse the repository at this point in the history

  2. Increased version number

    @Lemongrass3110
    Lemongrass3110 committed May 2, 2024
    Configuration menu
    Copy the full SHA
    e89d89e View commit details
    Browse the repository at this point in the history

Commits on May 4, 2024

  1. Synchronize Damage Feature 

    - Added a new config synchronize_damage, when set to "yes", the client will display the damage of normal monster attacks at the exact time it is applied on the server, removing position lag (fixes #259)
    @Playtester
    Playtester committed May 4, 2024
    Configuration menu
    Copy the full SHA
    82afe60 View commit details
    Browse the repository at this point in the history

  2. ClientAttackMotion Min and Default 

    - Added minimum value of 1 for ClientAttackMotion to prevent division by 0
- Changed default value from 432 to AttackMotion
    @Playtester
    Playtester committed May 4, 2024
    Configuration menu
    Copy the full SHA
    fae8477 View commit details
    Browse the repository at this point in the history

  3. Resolves invalid parsed values

    @aleos89
    aleos89 committed May 4, 2024
    Configuration menu
    Copy the full SHA
    2b02765 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2024

  1. Made synchronize_damage work together with delay_battle_damage

    @Playtester
    Playtester committed May 5, 2024
    Configuration menu
    Copy the full SHA
    d30e016 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Not sure if md can even be nullptr here, but I guess checking doesn't hurt.

Co-authored-by: Atemo <[email protected]>
    @Playtester @Atemo
    Playtester and Atemo committed May 5, 2024
    Configuration menu
    Copy the full SHA
    ef28d9e View commit details
    Browse the repository at this point in the history

  3. Ensure clientamotion is at least 1 already in constructor

    @Playtester
    Playtester committed May 5, 2024
    Configuration menu
    Copy the full SHA
    3bc4534 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Update ClientAttackMotion values 

    * Add missing values for cloned or special event type monsters.
* Update values for several monsters that was determined incorrect from the sprite parser.
    @aleos89
    aleos89 committed May 8, 2024
    Configuration menu
    Copy the full SHA
    70fdcba View commit details
    Browse the repository at this point in the history

  2. ClientAttackMotion cleanup part deux

    @aleos89
    aleos89 committed May 8, 2024
    Configuration menu
    Copy the full SHA
    31ad1f4 View commit details
    Browse the repository at this point in the history

  3. Added status_get_clientamotion and optimized implementation

    @Playtester
    Playtester committed May 8, 2024
    Configuration menu
    Copy the full SHA
    1262acd View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Apply suggestion: Check config first 

    Co-authored-by: Lemongrass3110 <[email protected]>
    @Playtester @Lemongrass3110
    Playtester and Lemongrass3110 committed May 20, 2024
    Configuration menu
    Copy the full SHA
    611e2c3 View commit details
    Browse the repository at this point in the history

  2. Code optimizations based on feedback from Lemongrass

    @Playtester
    Playtester committed May 20, 2024
    Configuration menu
    Copy the full SHA
    6586b56 View commit details
    Browse the repository at this point in the history

  3. Fixed spaces

    @Playtester
    Playtester committed May 20, 2024
    Configuration menu
    Copy the full SHA
    36e7923 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Removed != 0 check 

    Co-authored-by: Lemongrass3110 <[email protected]>
    @Playtester @Lemongrass3110
    Playtester and Lemongrass3110 committed May 21, 2024
    Configuration menu
    Copy the full SHA
    f1430ba View commit details
    Browse the repository at this point in the history

  2. Improved documentation and moved setting to battle.conf

    @Playtester
    Playtester committed May 21, 2024
    Configuration menu
    Copy the full SHA
    2fc675b View commit details
    Browse the repository at this point in the history

  3. Fixed problem that caused build to fail

    @Playtester
    Playtester committed May 21, 2024
    Configuration menu
    Copy the full SHA
    52fdaf7 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Unified the amotion calculation in battle_delay_damage

    @Playtester
    Playtester committed May 22, 2024
    Configuration menu
    Copy the full SHA
    a801950 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. Code optimization (easier to read)

    @Playtester
    Playtester committed May 25, 2024
    Configuration menu
    Copy the full SHA
    313109b View commit details
    Browse the repository at this point in the history

  2. Comment in battle.conf updated by Lemongrass 

    Co-authored-by: Lemongrass3110 <[email protected]>
    @Playtester @Lemongrass3110
    Playtester and Lemongrass3110 committed May 25, 2024
    Configuration menu
    Copy the full SHA
    308dafb View commit details
    Browse the repository at this point in the history