Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unlimited use of potion. #8286

Merged
merged 3 commits into from May 17, 2024
Merged

Fix unlimited use of potion. #8286

merged 3 commits into from May 17, 2024

Conversation

kaninhot004
Copy link
Contributor

  • Addressed Issue(s): None

  • Server Mode: Renewal

  • Description of Pull Request: Fix unlimited item use exploit.

@gmragnarok
Copy link

Is the correct script like this?

@kaninhot004
Copy link
Contributor Author

Not sure but at least it fix the unlimited use bug.

aleos89
aleos89 approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@aleos89 aleos89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only comment I have is if officially it's supposed to show the Kyrie skill effect or not.

@Lemongrass3110 Lemongrass3110 added component:database A fault that lies within the database of rAthena mode:renewal A fault that exists within the renewal mode status:code-review Pull Request that requires reviewing from other developers before being pushed to master type:bug Issue that is a bug within rAthena labels May 3, 2024
@Lemongrass3110 Lemongrass3110 requested a review from Atemo May 3, 2024 17:46
Atemo
Atemo reviewed May 3, 2024
View reviewed changes
Copy link
Contributor

@Atemo Atemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(the item was consumed after using the skill, not sure we can call it an exploit)

db/re/item_db_usable.yml Show resolved Hide resolved
@kaninhot004
Copy link
Contributor Author

More explaination: Use this item will heal you 100% HP and SP then cancel the cast. Repeat this forever.

@Atemo Atemo merged commit 4327fb0 into rathena:master May 17, 2024
2 checks passed
@Atemo Atemo removed the status:code-review Pull Request that requires reviewing from other developers before being pushed to master label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atemo Atemo Atemo left review comments

@aleos89 aleos89 aleos89 approved these changes

Assignees
No one assigned
Labels
component:database A fault that lies within the database of rAthena mode:renewal A fault that exists within the renewal mode type:bug Issue that is a bug within rAthena
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kaninhot004 @gmragnarok @aleos89 @Atemo @Lemongrass3110