Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expanded 4ths to jobmaster #8267

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vstumpf
Copy link
Member

@vstumpf vstumpf commented Apr 21, 2024

  • Server Mode: Renewal
  • Description of Pull Request: Add 4th expanded classes to the job master

I had to guess some of the values

@@ -504,6 +526,7 @@ OnInit:
setarray .Req_Fourth[0],200,70; // Minimum base level, job level to change to fourth class
setarray .Req_Exp_NJ_GS[0],99,70; // Minimum base level, job level to turn into Expanded Ninja and Gunslinger
setarray .Req_Exp_SNOVI[0],99,99; // Minimum base level, job level to turn into Expanded Super Novice
setarray .Req_SHandler[0],200,60; // Minimum base level, job level to turn into Spirit Handler
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if these are the correct levels

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.youtube.com/watch?v=kuCVZv21Amc

The person in this video is level 200/60.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

}

if (.FourthExpanded && .@eac == EAJ_SUPER_NOVICE_E) {
Require_Level(.Req_Fourth[0], .Req_Fourth[1]);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right levels?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The required level (200/70) is correct
https://www.divine-pride.net/tools/skilltree/4307

@vstumpf vstumpf added component:script A fault that lies within the scripts of rAthena mode:renewal A fault that exists within the renewal mode mode:prerenewal A fault that exists within the pre-renewal mode status:code-review Pull Request that requires reviewing from other developers before being pushed to master labels Apr 21, 2024
@LolyAll
Copy link

LolyAll commented Apr 21, 2024

Man do you will merge the missing jobs in main branch too?

This: #7024

@vstumpf
Copy link
Member Author

vstumpf commented Apr 21, 2024

Oh, they're not all in yet? Then probably not, I'll look at the ones that are actually implemented

@Atemo
Copy link
Contributor

Atemo commented Apr 21, 2024

The skills are missing, but the classes are implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:script A fault that lies within the scripts of rAthena mode:prerenewal A fault that exists within the pre-renewal mode mode:renewal A fault that exists within the renewal mode status:code-review Pull Request that requires reviewing from other developers before being pushed to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants