Fix dynamic npc timer mismatch

src/map/buyingstore.cpp

@@ -703,6 +703,7 @@ void do_init_buyingstore_autotrade( void ) {
 
  // initialize player
  CREATE(at->sd, map_session_data, 1); // TODO: Dont use Memory Manager allocation anymore and rely on the C++ container
+ new (at->sd) map_session_data();
  pc_setnewpc(at->sd, at->account_id, at->char_id, 0, gettick(), at->sex, 0);
  at->sd->state.autotrade = 1|4;
  if (battle_config.autotrade_monsterignore)

src/map/mob.cpp

@@ -194,6 +194,7 @@ void mvptomb_create(struct mob_data *md, char *killer, time_t time)
  mvptomb_destroy(md);
 
  CREATE(nd, struct npc_data, 1);
+ new (nd) npc_data();
 
  nd->bl.id = md->tomb_nid = npc_get_new_npc_id();
 
@@ -213,6 +214,10 @@ void mvptomb_create(struct mob_data *md, char *killer, time_t time)
  nd->u.tomb.kill_time = time;
  nd->u.tomb.spawn_timer = INVALID_TIMER;
 
+ nd->dynamicnpc.owner_char_id = 0;
+ nd->dynamicnpc.last_interaction = 0;
+ nd->dynamicnpc.removal_tid = INVALID_TIMER;
+
  if (killer)
  safestrncpy(nd->u.tomb.killer_name, killer, NAME_LENGTH);
  else

src/map/status.cpp

@@ -9417,9 +9417,7 @@ void status_change_init(struct block_list *bl)
 {
  status_change *sc = status_get_sc(bl);
  nullpo_retv(sc);
- memset(sc, 0, sizeof (status_change));
- sc->lastEffect = SC_NONE;
- sc->lastEffectTimer = INVALID_TIMER;
+ new (sc) status_change;
 }
 
 /*========================================== [Playtester]

src/map/status.hpp

@@ -3253,13 +3253,13 @@ struct status_change_entry {
 ///Status change
 class status_change {
 public:
- unsigned int option;// effect state (bitfield)
- unsigned int opt3;// skill state (bitfield)
- unsigned short opt1;// body state
- unsigned short opt2;// health state (bitfield)
- unsigned char count;
- sc_type lastEffect; // Used to check for stacking damageable SC on the same attack
- int32 lastEffectTimer; // Timer for lastEffect
+ unsigned int option{};// effect state (bitfield)
+ unsigned int opt3{};// skill state (bitfield)
+ unsigned short opt1{};// body state
+ unsigned short opt2{};// health state (bitfield)
+ unsigned char count{};
+ sc_type lastEffect{SC_NONE}; // Used to check for stacking damageable SC on the same attack
+ int32 lastEffectTimer{INVALID_TIMER}; // Timer for lastEffect
  //! TODO: See if it is possible to implement the following SC's without requiring extra parameters while the SC is inactive.
  struct {
  uint8 move;
@@ -3274,18 +3274,18 @@ class status_change {
  uint8 warp;
  uint8 deathpenalty;
  uint8 interact;
- } cant;/* status change state flags */
+ } cant{};/* status change state flags */
  //int sg_id; //ID of the previous Storm gust that hit you
- short comet_x, comet_y; // Point where src casted Comet - required to calculate damage from this point
+ short comet_x{}, comet_y{}; // Point where src casted Comet - required to calculate damage from this point
 /**
  * The Storm Gust counter was dropped in renewal
  **/
 #ifndef RENEWAL
- unsigned char sg_counter; //Storm gust counter (previous hits from storm gust)
+ unsigned char sg_counter{}; //Storm gust counter (previous hits from storm gust)
 #endif
 private:
- struct status_change_entry *data[SC_MAX];
- std::pair<enum sc_type, struct status_change_entry *> lastStatus; // last-fetched status
+ struct status_change_entry *data[SC_MAX]{nullptr};
+ std::pair<enum sc_type, struct status_change_entry *> lastStatus{SC_NONE, nullptr}; // last-fetched status
 
 public:
  status_change_entry * getSCE(enum sc_type type);

src/map/vending.cpp

@@ -617,6 +617,7 @@ void do_init_vending_autotrade(void)
 
  // initialize player
  CREATE(at->sd, map_session_data, 1); // TODO: Dont use Memory Manager allocation anymore and rely on the C++ container
+ new (at->sd) map_session_data();
  pc_setnewpc(at->sd, at->account_id, at->char_id, 0, gettick(), at->sex, 0);
  at->sd->state.autotrade = 1|2;
  if (battle_config.autotrade_monsterignore)