Optimized Swordsman tutorial quest #8251
Open
+150
−789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Daegaladh
commented
Apr 13, 2024
•
Daegaladh
commented
- Addressed Issue(s): N/A
- Server Mode: Both
- Description of Pull Request: Several optimizations to Swordsman tutorial quest
Daegaladh
added
component:script
Daegaladh
changed the title
Lemongrass3110
approved these changes
Apr 14, 2024
Atemo
reviewed
Apr 15, 2024
| mes "should go second?"; | ||
| next; | ||
| .@select = select(implode(.@menu$, ":")) - 1; | ||
| .@code$[1] = inarray(.@names_array$, .@menu$[.@select]); |
There was a problem hiding this comment.
inarray return int it's strange to store it in str
| .@code$[1] = inarray(.@names_array$, .@menu$[.@select]); | ||
| deletearray .@menu$[.@select], 1; | ||
| mes "[Dequ'ee]"; | ||
| mes .@names_array$[.@code$[1]] +"'s...?"; |
There was a problem hiding this comment.
index can't be string in this engine
| @@ -2068,7 +1428,8 @@ geffen,154,143,3 script Dequ'ee 734,{ | |||
| mes "be the message I'm supposed to receive from Shurack. I need his exact message or I can't send"; | |||
| mes "a response..."; | |||
| close; | |||
| case 2: | |||
| } | |||
| else { | |||
There was a problem hiding this comment.
For me else / else if should only be used if the code continue after the previous condition.
Daegaladh
added
the
status:inprogress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.