Initial implementation of Map Zones #8100
Open
+8,995
−11,149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implements Map Zones which allows easier configuration of map settings. * The restricted mapflag has been removed as they will no longer be needed. * General cleanups and optimizations.
aleos89
added
component:database
* Convert a few more PK damage checks that got missed from a merge conflict.
SapitoSucio
reviewed
Jan 12, 2024
SapitoSucio
reviewed
Jan 12, 2024
Thanks to @SapitoSucio!
* Deprecate the bg_flee_penalty and gvg_flee_penalty battle configs. * Removes hardcoded restrictions limiting to only BG and GvG maps.
* Adjust checks for faster lookup.
* Re-implement battle_calc_pk_damage to help determine when to adjust damage when PK mode is enabled. * Implement INF2_IGNOREPKREDUCTION skill flag to make skills bypass the damage adjustments.
* Remove a possible timer even if passing an invalid time value.
* Check by object type rather than passing arbitrary integers to compare against.
Atemo
reviewed
Jan 17, 2024
|
Can something like these be added?
It will be much easier to enable set of items only (ex: Booster equipment) |
Pokye
reviewed
Jan 17, 2024
Pokye
reviewed
Jan 17, 2024
* Added the Clear label to allow mapflags to be removed for importing use. * Converts mapflag storage into multimap.
* Adds back an accidental removal for mapflag name lookup.
* Display a notice when a map doesn't have a zone with a suggestion to assign one. * Avoiding a default zone as many maps are added from updates and may not get their proper zones until the requisite data is found.
Thanks to @Pokye!
* Fixes atcommands pvpon, pvpoff, gvgon, and gvgoff to properly toggle the current map with the appropriate zone. * Atcommand pvpon will assign the MAPTYPE_NOPENALTY_FREEPKZONE zone. * Atcommand gvgon will assign the MAPTYPE_EVENT_GUILDWAR zone. * Adds getMapZone() to return a map's zone. * Adds setZone() to set a map's zone. Thanks to @Atemo!
* Revert atcommand pvpon/pvpoff. * Revert atcommand gvgon/gvgoff.
I'll gladly accept this as a feature request after the initial implementation gets put in just to keep "custom" parts of this separate. |
* Adjust to class to avoid duplication of definitions. * Rename prefix to match "class".
Thanks to @Lemongrass3110!
# Conflicts: # conf/msg_conf/map_msg.conf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed Issue(s): N/A
Server Mode: Pre-renewal and Renewal
Description of Pull Request: