Refactoring of chat struct #8013
Open
+228
−280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converted C constructs to modern cpp * Conversion of regular arrays to std::array, that allows iterating and size info * Conversion of functions to class methods when appropriate * Conversion of Macros to inline constexpr for easier: ** Scoping ** Rebuild ** Debugging * Declaration and definition on the same line, the closest to where it's used * Removed class-specifiers when possible Converted unused int return types to void Added namespace chats:: Applied google guidelines for naming conventions * CamelCase for structs, classes, typedefs, templates and functions * Underscore for local variables and namespaces * A trailing _ for private members
vstumpf
requested changes
Feb 19, 2024
| struct block_list* owner; | ||
| uint32 min_level; // minimum base level to join | ||
| uint32 max_level; // maximum base level allowed to join | ||
| std::array<map_session_data*,MAX_CHAT_USERS> usersd; |
There was a problem hiding this comment.
Do we want an array here? can we use a vector instead? or is it so we don't have to change too much of the implementation
| int chat_changechatowner(map_session_data* sd, const char* nextownername); | ||
| int chat_changechatstatus(map_session_data* sd, const char* title, const char* pass, int limit, bool pub); | ||
| int chat_kickchat(map_session_data* sd, const char* kickusername); | ||
| void TriggerEvent(); |
There was a problem hiding this comment.
a nitpick, but we have more methods that are camelCase than PascalCase, I like the former more imo
Comment on lines
+20
to
+21
| uint32 users; // current user count | ||
| uint32 limit; // join limit |
There was a problem hiding this comment.
Is there a reason why to increase the storage of these?
if it's to keep in line with MAX_CHAT_USERS, we can either change the storage type of MAX_CHAT_USERS, or have some static_assert comparing with std::numeric_limit<decltype(ChatData::users)>::max()
|
|
||
| nullpo_ret(sd); | ||
| ChatData* cd = (ChatData*)map_id2bl(chatid); |
There was a problem hiding this comment.
we should replace every usage of (ChatData*)map_id2bl(chatid) with map_id2cd(chatid); we get the BL_CAST for free
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of chat struct
Converted C constructs to modern cpp
Converted unused int return types to void
Added namespace chats::
Applied google guidelines for naming conventions