Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dynamic npc timer mismatch #8265

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix dynamic npc timer mismatch #8265

wants to merge 2 commits into from
+20 −15

Conversation

vstumpf
Copy link
Member

@vstumpf vstumpf commented Apr 20, 2024

Fixes #8241
This adds some missing placement news that I'm surprised hasn't blown up yet.

  • Server Mode: Both
  • Description of Pull Request: Fix the dynamic npc timer mismatch. We forgot to set the removal_tid for tombs. This PR sets those, and adds some forgotten placement news. It also changes status_change_init to just call the status_change constructor

@vstumpf
Fix dynamic npc timer mismatch
7495f88 
Fixes rathena#8241
This adds some missing placement news that I'm surprised hasn't blown up yet.
@vstumpf vstumpf mentioned this pull request Apr 20, 2024
Open
@vstumpf vstumpf added component:core A fault that lies within the main framework of rAthena mode:renewal A fault that exists within the renewal mode mode:prerenewal A fault that exists within the pre-renewal mode status:code-review Pull Request that requires reviewing from other developers before being pushed to master labels Apr 21, 2024
Lemongrass3110
Lemongrass3110 requested changes Apr 24, 2024
View reviewed changes
src/map/status.cpp Outdated Show resolved Hide resolved
src/map/status.hpp
@@ -3253,13 +3253,13 @@ struct status_change_entry {
///Status change
class status_change {
public:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still against that syntax.

@vstumpf vstumpf enabled auto-merge (squash) April 27, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lemongrass3110 Lemongrass3110 Lemongrass3110 requested changes

@aleos89 aleos89 aleos89 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
component:core A fault that lies within the main framework of rAthena mode:prerenewal A fault that exists within the pre-renewal mode mode:renewal A fault that exists within the renewal mode status:code-review Pull Request that requires reviewing from other developers before being pushed to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

function mismatch 00007FF770B4E1C0(connect_check_clear) != 00007FF7702760BD(npc_dynamicnpc_removal_timer)
3 participants
@vstumpf @Lemongrass3110 @aleos89