-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: remove pre-push hooks #1115
Conversation
I assume the ci task is also run by GitHub actions so this PR should ensure the checks on GitHub should still test these things. Personally I stopped using the git hook / (Also, running I would also reorder the Makefile to keep the simple things first and then the more advanced ones. ratatui requiring me to use typos, make and nextest (especially automatically installing them without any confirmation on my side while using Grouping the makefile better in the suggested ways should help to easily see what will happen when running it. Then it’s easy to see what will be done by executing the command. There should not be a push hook especially one that installs random stuff without confirmation. |
It's not. This target could be called pre-push The GitHub CI process runs the individual makefile targets rather than any higher level one, so that these show up as parts of the GitHub Actions, so that they can be parallelized, and so that they can run against multiple operating systems.
The windows vs non-windows story is a pain for --all-features.
0.84s vs 4.49s on my machine. Got some contrasting numbers?
Are these visibly different without the --all-features?
Yeah, this is probably bad
I have no real concern over the order of the makefile. If there's a better order go for it. Basically the makefile works fine, doesn't greatly cause problems, so there's no real value in "fixing it". If there was, I'd be inclined to replace the makefile with a cargo xtask package, and dispense with needing cargo-make at all, but it's just not a high priority. I wonder if there's an easy way to git push, and then watch the github checks succeed / fail in the terminal. Somone 'aughta make an extension for gh that does that. |
|
Awesome. Thanks for pointing that out, you wouldn't believe how difficult it is to find the right google terms to get to this "github actions tui" etc. |
These were often skipped by developers due to being annoying. Instead make these optional to run before pushing.
Changed this PR to just remove the hooks. I usually skip running them locally and Ed just disables them entirely. |
Thank you, I also always disabled them 👍 . |
|
5s is definitely in the realm of fast enough for a manual run IMHO, but < 1s is fast enough for a workflow that runs tests on every save. Both seem reasonable use cases. |
No description provided.