Skip to content

Commit

Permalink
Use codecov from CI images (#23)
Browse files Browse the repository at this point in the history
* try `codecov` binary

changes `codecov` implementation to use binary instead of GH Action wrapper.
The GH Action wrapper seemed to intermittently fail. Hopefully using the binary directly fixes that

* debug codecov script

* use `codecov` in CI images

* ensure `codecov` only runs on `x86`/`x86_64` machines

* set `RAPIDS_TESTS_DIR` similarly to `RAPIDS_COVERAGE_DIR`

* enable `codecov` to run on nightlies

* update arch conditional
  • Loading branch information
ajschmidt8 authored Nov 30, 2022
1 parent f817334 commit 4bf3441
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 13 deletions.
7 changes: 3 additions & 4 deletions .github/workflows/conda-cpp-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ on:
extended_nightly_tests:
type: boolean
default: false
tests_result_dir:
type: string
default: "test-results"
test_script:
type: string
default: "ci/test_cpp.sh"
Expand Down Expand Up @@ -83,6 +80,8 @@ jobs:
- linux
- gpu-${{ matrix.includes.GPU }}-${{ matrix.includes.DRIVER }}-1
- ${{ matrix.includes.ARCH }}
env:
RAPIDS_TESTS_DIR: ${{ github.workspace }}/test-results
container:
image: rapidsai/ci:cuda${{ matrix.includes.CUDA_VER }}-${{ matrix.includes.LINUX_VER }}-py${{ matrix.includes.PY_VER }}
env:
Expand All @@ -108,5 +107,5 @@ jobs:
- name: Generate test report
uses: test-summary/action@v2
with:
paths: "${{ inputs.tests_result_dir }}/*.xml"
paths: "${{ env.RAPIDS_TESTS_DIR }}/*.xml"
if: always()
18 changes: 9 additions & 9 deletions .github/workflows/conda-python-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ on:
extended_nightly_tests:
type: boolean
default: false
tests_result_dir:
type: string
default: "test-results"
test_script:
type: string
default: "ci/test_python.sh"
Expand Down Expand Up @@ -88,6 +85,7 @@ jobs:
- ${{ matrix.includes.ARCH }}
env:
RAPIDS_COVERAGE_DIR: ${{ github.workspace }}/coverage-results
RAPIDS_TESTS_DIR: ${{ github.workspace }}/test-results
container:
image: rapidsai/ci:cuda${{ matrix.includes.CUDA_VER }}-${{ matrix.includes.LINUX_VER }}-py${{ matrix.includes.PY_VER }}
env:
Expand All @@ -113,10 +111,12 @@ jobs:
- name: Generate test report
uses: test-summary/action@v2
with:
paths: "${{ inputs.tests_result_dir }}/*.xml"
paths: "${{ env.RAPIDS_TESTS_DIR }}/*.xml"
if: always()
- uses: codecov/codecov-action@v3
if: inputs.run_codecov && inputs.build_type == 'pull-request'
with:
directory: ${{ env.RAPIDS_COVERAGE_DIR }}
verbose: true
- name: Run codecov
if: inputs.run_codecov && runner.arch == 'X64'
run: |
codecov \
-s \
"${RAPIDS_COVERAGE_DIR}" \
-v

0 comments on commit 4bf3441

Please sign in to comment.