-
Notifications
You must be signed in to change notification settings - Fork 225
[RELEASE] rmm v25.08 #1998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[RELEASE] rmm v25.08 #1998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forward-merge branch-25.06 into branch-25.08
Forward-merge branch-25.06 into branch-25.08
Branch 25.08 merge branch 25.06
Forward-merge branch-25.06 into branch-25.08
Forward-merge branch-25.06 into branch-25.08
Forward-merge branch-25.06 into branch-25.08
Forward-merge branch-25.06 into branch-25.08
Forward-merge branch-25.06 into branch-25.08
Contributes to rapidsai/build-planning#181 * removes all uploads of conda packages and wheels to `downloads.rapids.ai` ## Notes for Reviewers ### How I identified changes Looked for uses of the relevant `gha-tools` tools, as well as documentation about `downloads.rapids.ai`, being on the NVIDIA VPN, using S3, etc. like this: ```shell git grep -i -E 's3|upload|downloads\.rapids|vpn' ``` ### How I tested this See "How I tested this" on rapidsai/shared-workflows#364 # Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Jake Awe (https://github.com/AyodeAwe) URL: #1929
This PR removes CUDA 11 devcontainers and updates CI scripts. xref: rapidsai/build-planning#184 Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) URL: #1933
Forward-merge branch-25.06 into branch-25.08
Forward-merge branch-25.06 into branch-25.08
Forward-merge branch-25.06 into branch-25.08
xref rapidsai/build-planning#184 Authors: - Gil Forsyth (https://github.com/gforsyth) - Bradley Dice (https://github.com/bdice) - https://github.com/jakirkham Approvers: - Vyas Ramasubramani (https://github.com/vyasr) - Bradley Dice (https://github.com/bdice) URL: #1932
Issue: rapidsai/build-planning#184 Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) - Bradley Dice (https://github.com/bdice) - https://github.com/jakirkham Approvers: - Bradley Dice (https://github.com/bdice) URL: #1934
The `REPLAY_BENCH` benchmark is used for replaying logs of allocation patterns. However, unless one passes `--benchmark_repetitions=1` and `--benchmark_min_time=0s`, the replay hangs forever after the first warmup iteration. The problem is that a shared `event_index` needs to be reset for each benchmark iteration. Additionally, if running a multi-threaded allocation replay, there is a race condition between thread 0 setting up and tearing down the memory resource being used, and any other threads running through their allocation pattern. To fix these, now that we no longer support CUDA 11, require C++20 to compile the benchmarks and use a `std::barrier` to ensure ordering between `SetUp`/`TearDown` on thread 0 and the actual benchmark iteration. To handle the `event_index` problem, we again use barriers for sequencing. Thread 0 resets the `event_index` at the beginning of each benchmark iteration and then everyone waits at a barrier. - Closes #1939 Authors: - Lawrence Mitchell (https://github.com/wence-) - Bradley Dice (https://github.com/bdice) Approvers: - Peter Andreas Entschev (https://github.com/pentschev) - Rong Ou (https://github.com/rongou) - Bradley Dice (https://github.com/bdice) URL: #1940
Minor documentation fix for the Python package path. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) URL: #1936
Extend replay benchmark to include managed memory resource. Authors: - Peter Andreas Entschev (https://github.com/pentschev) - Bradley Dice (https://github.com/bdice) - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) URL: #1938
`rmm` is piloting the new branching strategy (https://docs.rapids.ai/notices/rsn0047/). This PR updates the branches which trigger a nightly/branch build in the new strategy.
This adds an env var to pass the github token through to the telemetry summary shared action. The token is necessary to check if the base artifact exists. See rapidsai/shared-actions#56 for more information. The whitespace changes here were introduced from using yq with rapids-reviser to add this field. If the whitespace changes are undesirable, I will revert them. Authors: - Mike Sarahan (https://github.com/msarahan) Approvers: - Bradley Dice (https://github.com/bdice) URL: #1956
This pull request implements the reverse iterators for the `device_uvector` type. Closes #1326 Authors: - Basit Ayantunde (https://github.com/lamarrr) - Bradley Dice (https://github.com/bdice) Approvers: - Mark Harris (https://github.com/harrism) - Bradley Dice (https://github.com/bdice) - Vyas Ramasubramani (https://github.com/vyasr) URL: #1937
Updates vendored cxxopts.hpp to 3.3.1. xref: #1951 (comment) Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Gil Forsyth (https://github.com/gforsyth) - Mark Harris (https://github.com/harrism) - Vyas Ramasubramani (https://github.com/vyasr) URL: #1962
Make RMM easier to BUILD with LLVM: - add missing #includes; - do not require nvtx headers when its configured not to use nvtx. closes #1948 . Authors: - https://github.com/vitor1001 - Bradley Dice (https://github.com/bdice) - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Bradley Dice (https://github.com/bdice) - Mark Harris (https://github.com/harrism) URL: #1951
Erasing from `allocations_` invalidates all iterators, so dereferencing `found` is Undefined Behaviour. In practice, we're seeing completely messed up tracking. closes #1965 Authors: - Clement Courbet (https://github.com/legrosbuffle) - Bradley Dice (https://github.com/bdice) Approvers: - Bradley Dice (https://github.com/bdice) URL: #1966
This is Undefined Behaviour. closes #1967 Authors: - Clement Courbet (https://github.com/legrosbuffle) Approvers: - Bradley Dice (https://github.com/bdice) - Rong Ou (https://github.com/rongou) URL: #1968
Testing the changes from rapidsai/gha-tools#196, which contribute to rapidsai/shared-workflows#377 I'm proposing that we **merge this as-is**, to test that these changes work in the following situations on `main`: * `branch` build triggered by a merge * manually-triggered `nightly` test run Then merge a follow-up PR reverting all of this, after rapidsai/gha-tools#196 is merged. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) URL: #1972
Reverts #1972, which was just merged to test the changes from rapidsai/gha-tools#196 for `branch` / `nightly` builds. Created like this: ```shell git revert d07133f ``` Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) URL: #1974
Use CUDA 12.9 throughout different build and test environments. Authors: - https://github.com/jakirkham Approvers: - Gil Forsyth (https://github.com/gforsyth) URL: #1973
Contributes to rapidsai/shared-workflows#376 * adds descriptions for all inputs to workflows triggered by `workflow_dispatch` ## Notes for Reviewers ### Motivation The input descriptions show up in the UI when you go to trigger these workflows. Like this:  I'm hoping that will make it easier for developers to manually trigger workflows. Inspired by being asked multiple times "what format is `date` supposed to be in?". # Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) URL: #1975
Continues from #1896. Contributes to #1779. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Lawrence Mitchell (https://github.com/wence-) - Rong Ou (https://github.com/rongou) - Robert Maynard (https://github.com/robertmaynard) URL: #1980
updates: - [github.com/astral-sh/ruff-pre-commit: v0.11.4 → v0.12.2](astral-sh/ruff-pre-commit@v0.11.4...v0.12.2) - [github.com/MarcoGorelli/cython-lint: v0.16.6 → v0.16.7](MarcoGorelli/cython-lint@v0.16.6...v0.16.7) - [github.com/pre-commit/mirrors-clang-format: v20.1.4 → v20.1.7](pre-commit/mirrors-clang-format@v20.1.4...v20.1.7) - [github.com/rapidsai/pre-commit-hooks: v0.6.0 → v0.7.0](rapidsai/pre-commit-hooks@v0.6.0...v0.7.0) - [github.com/rapidsai/dependency-file-generator: v1.18.1 → v1.19.1](rapidsai/dependency-file-generator@v1.18.1...v1.19.1) Authors: - https://github.com/apps/pre-commit-ci - Bradley Dice (https://github.com/bdice) Approvers: - Bradley Dice (https://github.com/bdice) URL: #1979
I am not sure if this is the correct method to ensure librmm is built and found when building / installing the rmm Python package, but this has worked for me. Fixes #1977 Authors: - Graham Markall (https://github.com/gmarkall) Approvers: - Bradley Dice (https://github.com/bdice) URL: #1978
This PR updates RMM to require CUDA 12.0+. This drops version checks less than 12.0 and updates some enums to use values defined in CUDA 12.0+. Closes #1745. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Tom Augspurger (https://github.com/TomAugspurger) - Yunsong Wang (https://github.com/PointKernel) - Shruti Shivakumar (https://github.com/shrshi) - Matthew Murray (https://github.com/Matt711) URL: #1984
…1987) In rapidsai/build-planning#187 we switched the docker image tagging scheme over to include the CalVer information. This was done to allow us to make changes to the images during burndown without breaking release pipelines. This PR moves all of the existing `latest` tags to the newer versioned tag `25.08-latest` and also modifies the `update_version.sh` script to bump that version at branch creation time. xref: rapidsai/build-planning#187 Authors: - Gil Forsyth (https://github.com/gforsyth) Approvers: - James Lamb (https://github.com/jameslamb) URL: #1987
Removing a line that does nothing from `update-version.sh` xref #1987 Authors: - Gil Forsyth (https://github.com/gforsyth) Approvers: - Bradley Dice (https://github.com/bdice) URL: #1989
This reverts commit db325e6. We've rolled back most of the changes associated with the new branching model, but this also needs to be reverted. Authors: - Gil Forsyth (https://github.com/gforsyth) Approvers: - Bradley Dice (https://github.com/bdice) URL: #1988
Closes #1318. This uses `device_uvector<T>::size_type` instead of hardcoding `std::size_t` in its implementation. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) - David Wendt (https://github.com/davidwendt) URL: #1992
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❄️ Code freeze for
branch-25.08
and v25.08 releaseWhat does this mean?
Only critical/hotfix level issues should be merged into
branch-25.08
until release (merging of this PR).What is the purpose of this PR?
branch-25.08
intomain
for the release