Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default value for PARALLEL_LEVEL to nproc #1566

Closed
wants to merge 2 commits into from

Conversation

jjacobelli
Copy link
Contributor

Description

The PARALLEL_LEVEL variable is used in CI to set parallel level while building. Currently this variable is set on the GHA runners to nproc, but as this is a RAPIDS specific variable, this variable will soon be removed from the runners, so RAPIDS projects must explicitly set this variable to nproc. This PR is setting the default value of PARALLEL_LEVEL to nproc to match what is done by other RAPIDS projects

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jjacobelli jjacobelli added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels May 21, 2024
@jjacobelli jjacobelli self-assigned this May 21, 2024
@jjacobelli jjacobelli marked this pull request as ready for review May 21, 2024 14:36
@jjacobelli jjacobelli requested a review from a team as a code owner May 21, 2024 14:36
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one quick question.

build.sh Outdated Show resolved Hide resolved
Signed-off-by: Jordan Jacobelli <[email protected]>
@jjacobelli
Copy link
Contributor Author

Closed in favor of rapidsai/gha-tools#108

@jjacobelli jjacobelli closed this May 30, 2024
@jjacobelli jjacobelli deleted the fix-parallel branch May 30, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants