Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use memory resource in DeviceBuffer #1132

Draft
wants to merge 4 commits into
base: branch-23.06
Choose a base branch
from

Conversation

jakirkham
Copy link
Member

Description

  • Accept DeviceMemoryResource in DeviceBuffer's constructor
  • Update to_device methods/functions to take a DeviceMemoryResource argument
  • Add a Stream & DeviceMemoryResource to copy

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the Python Related to RMM Python API label Oct 18, 2022
@jakirkham jakirkham added feature request New feature or request non-breaking Non-breaking change labels Oct 18, 2022
Update the C++ constructors to take `device_memory_resource` arguments.
This means that this argument is now required (at least based on the
constructors defined here) when calling `device_buffer` constructors.
Update the Python constructor to take and handle a
`DeviceMemoryResource` argument. Also pass this through to
`device_buffer` constructors.
Changes `copy` to allow a memory resource to be specified (using the
default device memory resource if unspecified). Also accepts a `stream`
argument (similar to other functions).
While the `to_device` function already included a memory resource, it
didn't use it. Plus other functions calling `to_device` did not use the
argument. The change here makes sure `to_device` passes this to the
`DeviceBuffer` constructor. Also it makes sure other functions have a
default argument, which they set if one is not specified.
@harrism
Copy link
Member

harrism commented Mar 28, 2023

Moving to 23.06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Non-breaking change Python Related to RMM Python API
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants