Use memory resource in DeviceBuffer
#1132
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
added
feature request
Update the C++ constructors to take `device_memory_resource` arguments. This means that this argument is now required (at least based on the constructors defined here) when calling `device_buffer` constructors.
Update the Python constructor to take and handle a `DeviceMemoryResource` argument. Also pass this through to `device_buffer` constructors.
Changes `copy` to allow a memory resource to be specified (using the default device memory resource if unspecified). Also accepts a `stream` argument (similar to other functions).
While the `to_device` function already included a memory resource, it didn't use it. Plus other functions calling `to_device` did not use the argument. The change here makes sure `to_device` passes this to the `DeviceBuffer` constructor. Also it makes sure other functions have a default argument, which they set if one is not specified.
jakirkham
force-pushed
the
use_mr_devbuf
branch
from
a6f8bcb to
a66a255
Compare
|
Moving to 23.06 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DeviceMemoryResourceinDeviceBuffer's constructorto_devicemethods/functions to take aDeviceMemoryResourceargumentStream&DeviceMemoryResourcetocopyChecklist