Skip to content

Conversation

robertmaynard
Copy link
Contributor

On a tegra machine which has a single GPU and CPU memory pool we can't request spilling back to CPU since it doesn't make sense. So on those style of machines we don't set a limit

@robertmaynard robertmaynard requested a review from a team as a code owner August 28, 2025 15:32
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for submitting this fix, Robert!

@jakirkham jakirkham added bug Something isn't working non-breaking Non-breaking change labels Aug 28, 2025
@jakirkham
Copy link
Member

One CI job failed due to missing test data

FAILED tests/utils/test_dataset.py::test_reader[dataset0] - RuntimeError: The datafile /tmp/pytest-of-root/pytest-1/popen-gw0/test_download_dataset10_0/karate.csv does not exist. Try setting download=True to download the datafile
FAILED tests/utils/test_dataset.py::test_reader[dataset1] - RuntimeError: The datafile /tmp/pytest-of-root/pytest-1/popen-gw0/test_download_dataset10_0/dolphins.csv does not exist. Try setting download=True to download the datafile
FAILED tests/utils/test_dataset.py::test_reader[dataset2] - RuntimeError: The datafile /tmp/pytest-of-root/pytest-1/popen-gw0/test_download_dataset10_0/polbooks.csv does not exist. Try setting download=True to download the datafile

Went ahead and restarted that job

@jnke2016
Copy link
Contributor

@jakirkham the datasets seems to be missing for those tests (probably deleted). I believe this is a known issue so we are taking a look into this

@rlratzel
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit c24f4fa into rapidsai:branch-25.10 Aug 29, 2025
232 of 238 checks passed
@jakirkham
Copy link
Member

Thanks all! 🙏

the datasets seems to be missing for those tests (probably deleted). I believe this is a known issue so we are taking a look into this

Sounds good. Thanks Joseph! 🙏

Is there an issue tracking the missing test data?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants