Log warning when sf or ch_names are ignored #207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This minor PR adds clarification surrounding a question in #156 about the
ch_names
parameter. I'm just implementing direct suggestions from there to provide clarity for the user:Raising an AssertionError instead of a warning might make more sense, as assertion checks are used in the opposite case a few lines later (i.e., when
data
is specified andsf
is not). But I didn't want to break anyone's existing code in case they passed sf through for logistical reasons or something. Happy to change if anyone prefers it as a raised error.