Skip to content

feat: migrate Safepal to use Hub #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: next
Choose a base branch
from

Conversation

arlert-armin
Copy link
Collaborator

Summary

Safepal has been migrated to Hub

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Implemented a user interface (UI) change, referencing our Figma design to ensure pixel-perfect precision.

Copy link
Collaborator

@RyukTheCoder RyukTheCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tnx for your contribution, I just added some minor comments. Also when I switch my account, it refreshes the page and the wallet gets disconnected. Please investigate this case and make sure we have implemented it the correct way and how safepal handles switch account.

Copy link
Collaborator

@RyukTheCoder RyukTheCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arlert-armin arlert-armin force-pushed the feat/rf-2139-migrate-safepal-to-hub branch from 79e54f6 to da0e1ea Compare June 11, 2025 09:58
@arlert-armin arlert-armin force-pushed the feat/rf-2139-migrate-safepal-to-hub branch from da0e1ea to fedbc01 Compare June 11, 2025 11:50
@arlert-armin arlert-armin force-pushed the feat/rf-2139-migrate-safepal-to-hub branch 2 times, most recently from a85571f to a663316 Compare June 15, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants