Skip to content

fix: fix dynamic height feature #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

Ikari-Shinji-re
Copy link
Member

Summary

Previously, the dynamic height calculation for the widget used the offsetTop relative to its parent element, rather than to the top of the viewport. This caused issues when the widget was nested within other elements, resulting in incorrect height calculations. This issue is now resolved in the new changes
Additionally, we’ve introduced a configuration option that allows widget users to specify a custom offsetBottom value when using dynamic height mode.

How did you test this change?

You can test these changes by decreasing the browser window width and adjusting the viewport height. Additionally, you can add elements above the widget in the app to check the effect of the offset on the widget's height.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Implemented a user interface (UI) change, referencing our Figma design to ensure pixel-perfect precision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants