fix: fix dynamic height feature #1210
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, the dynamic height calculation for the widget used the
offsetTop
relative to its parent element, rather than to the top of the viewport. This caused issues when the widget was nested within other elements, resulting in incorrect height calculations. This issue is now resolved in the new changesAdditionally, we’ve introduced a configuration option that allows widget users to specify a custom
offsetBottom
value when using dynamic height mode.How did you test this change?
You can test these changes by decreasing the browser window width and adjusting the viewport height. Additionally, you can add elements above the widget in the app to check the effect of the offset on the widget's height.
Checklist: