refactor: remove dependency to legacy getSigners #1187
+82
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyukTheCoder
requested review from
mikasackermn,
RanGojo and
yeager-eren
as code owners
yeager-eren
reviewed
Jun 25, 2025
There was a problem hiding this comment.
took a look at it and looks good to me. @arlert-armin please do a review on this.
RyukTheCoder
force-pushed
the
refactor/rf-2500-remove-dependency-to-legacy-get-signers
branch
from
727b3a9 to
9334eef
Compare
RyukTheCoder
force-pushed
the
refactor/rf-2500-remove-dependency-to-legacy-get-signers
branch
from
9334eef to
2d1b497
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactored
useHubAdapterto eliminate its dependency on the legacy providers'getSignersmethod. This was achieved by introducing asignersproperty directly within each provider's info object as a workaround.How did you test this change?
Tested by trying to sign transactions on hub wallets.
Checklist: