Skip to content

refactor: remove dependency to legacy provider on get signers #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

RyukTheCoder
Copy link
Collaborator

Summary

Partially removed the dependency to legacy provider on getSigners method in useHubAdapter. As the first step, the dependency for EVM and Solana namespace is removed in this PR and the dependency for other namespaces will be removed as well.

Key changes

  • Register new hub specific signers in getSigners method of useHubAdapter
  • Added getInstance, signMessage, sendTransaction actions to EVM namespace in wallets/core and Phantom provider
  • Added getInstance, signMessage, signTransaction actions to Solana namespace in wallets/core and Phantom provider

How did you test this change?

Tested by signing and sending transactions on evm and solana blockchains.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Implemented a user interface (UI) change, referencing our Figma design to ensure pixel-perfect precision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants