Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor docs and add active directory docs #229

Merged
merged 7 commits into from
Jun 3, 2024

Conversation

aiyengar2
Copy link

No description provided.

@aiyengar2 aiyengar2 changed the title Refactor docs Refactor docs and add active directory docs Feb 6, 2024
@aiyengar2 aiyengar2 force-pushed the active_directory_docs branch 4 times, most recently from 6d1f539 to b884534 Compare February 6, 2024 21:04
@aiyengar2 aiyengar2 force-pushed the active_directory_docs branch 5 times, most recently from a8fe9cb to 7debf23 Compare February 7, 2024 20:07
@aiyengar2 aiyengar2 marked this pull request as ready for review February 7, 2024 20:08
Copy link
Contributor

@HarrisonWAffel HarrisonWAffel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! A few comments on things that could be added

Copy link

@markusewalker markusewalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM, just one nit for now. When using the docs in the future, we can address anything that comes up at that time.

Copy link

This repository uses an automated workflow to automatically label pull requests which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community pull requests better. If the pull request is still relevant, please add a comment to the pull request so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the pull request in 14 days. Thank you for your contributions.

Copy link

@markusewalker markusewalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aiyengar2 aiyengar2 merged commit c994744 into rancher:main Jun 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants