Refactor e2e cleanup behavior for SKIP_RESOURCE_CLEANUP and SkipDeletionTest #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-demicev
previously approved these changes
Mar 19, 2025
salasberryfin
previously approved these changes
Mar 20, 2025
valaparthvi
changed the title
|
@valaparthvi Can you please add the table from the “Special notes for your reviewer” section into |
Signed-off-by: Parthvi Vala <parthvi.vala@suse.com>
Signed-off-by: Parthvi Vala <parthvi.vala@suse.com>
valaparthvi
dismissed stale reviews from salasberryfin and alexander-demicev
via
5ba722a
valaparthvi
force-pushed
the
cleanup-refactor
branch
from
940c79a to
5ba722a
Compare
valaparthvi
changed the title
…Dump to before charts uninstallation and management cluster deletion Signed-off-by: Parthvi Vala <parthvi.vala@suse.com>
valaparthvi
force-pushed
the
cleanup-refactor
branch
from
5ba722a to
48d1ab5
Compare
alexander-demicev
approved these changes
Mar 21, 2025
Danil-Grigorev
approved these changes
Mar 21, 2025
yiannistri
pushed a commit
to yiannistri/turtles
that referenced
this pull request
Mar 21, 2025
…ionTest (rancher#1161) * Refactor e2e cleanup Signed-off-by: Parthvi Vala <parthvi.vala@suse.com> * Revert focus on test Signed-off-by: Parthvi Vala <parthvi.vala@suse.com> * Add data to e2e/readme, refactor the behavior, move BootstrapArtifactDump to before charts uninstallation and management cluster deletion Signed-off-by: Parthvi Vala <parthvi.vala@suse.com> --------- Signed-off-by: Parthvi Vala <parthvi.vala@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kind/refactor
What this PR does / why we need it:
This PR adds a minor refactor to e2e cleanup. Currently, if
SkipDeletionTestis true, the cluster resources get deleted anyway since the git repo is deleted. There seem to be discrepancy in the way resources are cleaned up.This PR mainly attempts to reinforce the following behavior:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
It is best to run the changes locally with the following options:
Once these changes are accepted, I will make similar changes to backuprestore and other test suites.
Checklist: