Do not use default namespace in AKS e2e example #1149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
alexander-demicev
requested changes
Mar 17, 2025
Danil-Grigorev
previously approved these changes
Mar 18, 2025
mjura
force-pushed
the
e2e-aks-namespace
branch
from
09d218a to
8c47bf2
Compare
mjura
force-pushed
the
e2e-aks-namespace
branch
from
8c47bf2 to
42dc941
Compare
alexander-demicev
approved these changes
Mar 18, 2025
anmazzotti
requested changes
Mar 19, 2025
| spec: | ||
| allowedNamespaces: {} | ||
| clientID: ${AZURE_CLIENT_ID} | ||
| clientSecret: | ||
| name: cluster-identity-secret | ||
| namespace: capz-system | ||
| namespace: ${NAMESPACE} |
There was a problem hiding this comment.
This is going to break the test. The Secret is actually in the capz-system namespace (it's reused across tests).
There was a problem hiding this comment.
According our documentation: Note that the AzureClusterIdentity is a namespaced resource and it needs to be created in the same namespace as the Cluster. https://turtles.docs.rancher.com/turtles/next/en/user/clusterclass.html#_setup
There was a problem hiding this comment.
@mjura The documentation is correct. The line I mentioned however is a Secret reference.
The Secret is in capz-system, the AzureClusterIdentity is not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: