Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic P0 Test Cases for Project #45381

Merged
merged 1 commit into from May 23, 2024
Merged

Generic P0 Test Cases for Project #45381

merged 1 commit into from May 23, 2024
+542 −104

Conversation

Priyashetty17
Copy link
Contributor

@Priyashetty17 Priyashetty17 commented May 6, 2024 •
edited

Issue: rancher/qa-tasks#1248

Note: 2.8 Backport PR will be created once this gets approved

@Priyashetty17 Priyashetty17 force-pushed the generic-P0projects-1248 branch 5 times, most recently from d61d3f0 to 0bb9096 Compare May 10, 2024 14:36
anupama2501
anupama2501 reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@anupama2501 anupama2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a few questions and comments

tests/v2/validation/projects/projects_test.go Outdated Show resolved Hide resolved
tests/v2/validation/projects/projects_test.go Show resolved Hide resolved
tests/v2/validation/projects/projects_test.go Show resolved Hide resolved
tests/v2/validation/projects/projects_test.go Show resolved Hide resolved
tests/v2/validation/projects/projects.go Show resolved Hide resolved
tests/v2/validation/projects/projects_test.go Show resolved Hide resolved
tests/v2/validation/projects/projects_test.go Outdated Show resolved Hide resolved
tests/v2/validation/projects/projects_test.go Show resolved Hide resolved
anupama2501
anupama2501 reviewed May 13, 2024
View reviewed changes
tests/v2/validation/projects/projects_test.go Outdated Show resolved Hide resolved
tests/v2/validation/projects/projects.go Outdated Show resolved Hide resolved
tests/v2/validation/projects/projects.go Outdated Show resolved Hide resolved
joesims22
joesims22 reviewed May 14, 2024
View reviewed changes
Copy link

@joesims22 joesims22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nit comments, other than that PR lgtm

tests/v2/validation/projects/projects_test.go Outdated Show resolved Hide resolved
@Priyashetty17 Priyashetty17 mentioned this pull request May 22, 2024
Open
@Priyashetty17 Priyashetty17 force-pushed the generic-P0projects-1248 branch 2 times, most recently from 212f452 to 842c6a1 Compare May 22, 2024 15:41
joesims22
joesims22 approved these changes May 22, 2024
View reviewed changes
Copy link

@joesims22 joesims22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Priyashetty17 Priyashetty17 added the automation-enhancement To indicate this is related to enhancements in code related to automation label May 23, 2024
@Priyashetty17 Priyashetty17 merged commit 64937ab into rancher:release/v2.9 May 23, 2024
2 checks passed
@Priyashetty17 Priyashetty17 mentioned this pull request May 23, 2024
Open
@Priyashetty17 Priyashetty17 deleted the generic-P0projects-1248 branch May 23, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anupama2501 anupama2501 anupama2501 approved these changes

@joesims22 joesims22 joesims22 approved these changes

@brudnak brudnak Awaiting requested review from brudnak

@dasarinaidu dasarinaidu Awaiting requested review from dasarinaidu

Assignees
No one assigned
Labels
automation-enhancement To indicate this is related to enhancements in code related to automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Priyashetty17 @anupama2501 @joesims22