Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MachinePool support #582

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Conversation

anmazzotti
Copy link
Contributor

@anmazzotti anmazzotti commented Feb 25, 2025

kind/feature

What this PR does / why we need it:

This PR adds support for MachinePool, plus some refactoring.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #569

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@anmazzotti anmazzotti requested a review from a team as a code owner February 25, 2025 10:24
@anmazzotti anmazzotti self-assigned this Feb 25, 2025
@anmazzotti anmazzotti marked this pull request as draft February 25, 2025 10:25
@anmazzotti anmazzotti force-pushed the support_machine_pools branch 9 times, most recently from 25b9eb8 to b45cfd3 Compare February 26, 2025 12:22
@anmazzotti anmazzotti marked this pull request as ready for review February 26, 2025 14:05
Signed-off-by: Andrea Mazzotti <[email protected]>
@anmazzotti anmazzotti force-pushed the support_machine_pools branch from b45cfd3 to ef1a157 Compare February 26, 2025 14:58
Copy link
Member

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@anmazzotti anmazzotti merged commit b8cf46a into rancher:main Feb 28, 2025
9 checks passed
@furkatgofurov7
Copy link
Contributor

@anmazzotti thanks for the PR. Can we also document how to enable and use this feature with example(s) in the book?

@anmazzotti
Copy link
Contributor Author

anmazzotti commented Feb 28, 2025

@furkatgofurov7 it is enabled by default.
Also none of the flags is documented right now, so not really sure what to do.
Do you want me to document them all? Shall this be a dedicated page?

Additionally, most of the flags are not configurable even by the end user, so that needs to be sanitized first in the *-components.yaml file

FYI: #588

@furkatgofurov7
Copy link
Contributor

Do you want me to document them all? Shall this be a dedicated page?

Additionally, most of the flags are not configurable even by the end user, so that needs to be sanitized first in the *-components.yaml file

FYI: #588

I was thinking we could start documenting MP specific flag and extend the doc later as needed for other flags in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

RKE2Config support for MachinePools
4 participants