pushprox: fix hardcoded ipv4 #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandreLamarre
requested changes
Feb 27, 2024
| @@ -51,7 +51,7 @@ var ( | |||
| metricsAddr = kingpin.Flag("metrics-addr", "Serve Prometheus metrics at this address").Default(":9369").String() | |||
| tokenPath = kingpin.Flag("token-path", "Uses an OAuth 2.0 Bearer token found in this path to make scrape requests").String() | |||
| insecureSkipVerify = kingpin.Flag("insecure-skip-verify", "Disable SSL security checks for client").Default("false").Bool() | |||
| useLocalhost = kingpin.Flag("use-localhost", "Use 127.0.0.1 to scrape metrics instead of FQDN").Default("false").Bool() | |||
| useLocalhost = kingpin.Flag("use-localhost", "Use localhost to scrape metrics instead of FQDN").Default("false").Bool() | |||
There was a problem hiding this comment.
I think I would prefer having a separate boolean flag for using ipv6, in general I think its better to have explict bindings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the --use-localhost flag doesn't account for ipv6 only clusters. This small PR fixe the issue.
I have no idea how to fix properly Dockerfile.dapper, the changes I introduced allowed me to build the image and test it locally, fixing my issue, but most probably one need to make some changes/updates to the Dockerfile