This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
Allow crossed() methods with np.integer types #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bad behaviour when passing in a np.integer type instead of a regular integer `crossed_above(series, 25)` does work, while `crossed_above(series, np.int64(25))` does not work. On it's own, this is not a problem, however, it can become a problem depending where the 2nd variable came from.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bad behaviour when passing in a
np.integertype instead of a regular integercrossed_above(series, 25)does work, whilecrossed_above(series, np.int64(25))does not work.Obviously, np.floating uses the same, but for floating point operators.
On it's own, this is not a problem as you can pick how to create the integer, however, it can become a problem depending where the 2nd variable came from, for example if it comes from a ml library