Feature/workout #17
Open
Feature/workout #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 8, 2017
| = f.number_field :set, class: 'user_workout_input center_text', placeholder: 'sets' | ||
| .col-xs-2.center_text | ||
| -#%h2.user_workout_input 12 | ||
| = f.number_field :rep, class: 'user_workout_input center_text', placeholder: 'reps' |
| = f.number_field :weight, class: 'user_workout_input center_text', placeholder: 'wts' | ||
| .col-xs-2.center_text | ||
| -#%h2.user_workout_input 3 | ||
| = f.number_field :set, class: 'user_workout_input center_text', placeholder: 'sets' |
| %h2 12 | ||
| .col-xs-2.center_text | ||
| -#%h2.user_workout_input 30 | ||
| = f.number_field :weight, class: 'user_workout_input center_text', placeholder: 'wts' |
| -#%h2.user_workout_input 3 | ||
| = f.number_field :set, class: 'user_workout_input center_text', placeholder: 'sets' | ||
| .col-xs-2.center_text | ||
| -#%h2.user_workout_input 12 |
There was a problem hiding this comment.
Comment should have a space after the #
| -#%h2.user_workout_input 30 | ||
| = f.number_field :weight, class: 'user_workout_input center_text', placeholder: 'wts' | ||
| .col-xs-2.center_text | ||
| -#%h2.user_workout_input 3 |
There was a problem hiding this comment.
Comment should have a space after the #
| @@ -30,7 +30,7 @@ $ -> | |||
| $('#workout_grid').hide() | |||
| $('#workout_form').fadeIn( 500 ) | |||
| #$('#new_user_workout').fadeIn( 500 ) | |||
| $('#load_image').html( "<img src=\"" + w._image_url() + "\" width='90' height='90' />" ).addClass( "workout_image" ) | |||
| $('#load_image').html( "<img src=\"" + w._image_url() + "\" width='100' height='100' />" ).addClass( "workout_image" ) | |||
There was a problem hiding this comment.
Line exceeds maximum allowed length. Length is 122, max is 80.
houndci-bot
reviewed
Oct 19, 2017
| %h2 12 | ||
| = f.hidden_field :workout_id, value: 1 | ||
| .col-xs-2.center_text | ||
| -#%h2.user_workout_input 30 |
There was a problem hiding this comment.
Comment should have a space after the #
| = f.hidden_field :workout_id, value: 1 | ||
| .col-xs-2.center_text | ||
| -#%h2.user_workout_input 30 | ||
| = f.number_field :weight, class: 'user_workout_input center_text', placeholder: 'wts' |
| @@ -79,6 +80,8 @@ def user_workout_params | |||
| end | |||
|
|
|||
| def _workout | |||
| foo = Hash.new | |||
There was a problem hiding this comment.
Use hash literal {} instead of Hash.new.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for style violation using Hound/Ci