Removed hard coded IPs from addClient function #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed hard coded IP addresses from addClient funtion, so default IPs can be changed and client IPs will be generated in the correct subnet. Also made client config counting more robust.
Added a public IPv4 detection through third party APIs which does not depend on dig. This can be used where dig is not installed e.g. Cent OS.
Added a check to exit the script if PiHole installation fails, as there is no point in going further.
Fixed /etc/wireguard folder permissions on Fedore/CentOS. It turned out that with chmod 600 sysctl cannot read the folder contents while starting wg-quick so it fails with "wg0.conf does not exist" error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPs were hard coded in addClient function which prevented users from changing the default subnets.
The script does tell the user not to change the defaults, but changing IPs can be useful for advanced users. Ending up with client configs with wrong IPs is quite inconvenient.
So I have changed the addClient function to use the correct subnets from the params file saved during setup.
Also changed IPv4 detection when dig is not available and fixed some small issues which came up during testing the changes.
Code has been tested on Ubuntu, Debian, CentOS and Fedora (the latest versions available on google cloud)