Skip to content

Opportunity to reuse and extend AvatarComponent used for RainbowKitProvider. #2485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

soul4code
Copy link

@soul4code soul4code commented Jul 18, 2025

Now AvatarComponentProps is not exported from packages/rainbowkit/src/index.ts. I want to do something like:

interface CustomAvatarProps extends AvatarComponentProps {
    onLoad?: () => void;
}

const MyCustomAvatar: AvatarComponent<CustomAvatarProps> = ({address, ensImage, size, onLoad}) => {
    ....
}

PR-Codex overview

This PR enhances the AvatarComponent type definition in AvatarContext.ts to allow for generic props, improving flexibility. It also updates the exports in index.ts to include AvatarComponentProps.

Detailed summary

  • Updated AvatarComponent type to accept generic props in AvatarContext.ts.
  • Changed export statements in index.ts to include AvatarComponentProps along with AvatarComponent.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@soul4code soul4code requested a review from a team as a code owner July 18, 2025 08:16
Copy link

changeset-bot bot commented Jul 18, 2025

⚠️ No Changeset found

Latest commit: a3b6c28

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jul 18, 2025

@soul4code is attempting to deploy a commit to the rainbowdotme Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant