Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7-2-stable] Fix changelogs lint for trailing whitespaces #51858

Merged
merged 1 commit into from
May 18, 2024

Conversation

zzak
Copy link
Member

@zzak zzak commented May 18, 2024

Due to PR #51841 being created before rails/buildkite-config#105 was merged, lint job was still skipped and therefor we missed it.

Btw, if you need to test this locally you can run this from the root of your rails checkout:

$ bundle exec tools/railspect changelogs .

For example:

~/code/rails => bundle exec tools/railspect changelogs .
E.......E.E.E

Offenses:

actioncable/CHANGELOG.md:11 Trailing whitespace detected.

^^^^
activerecord/CHANGELOG.md:41 Trailing whitespace detected.
*   Add `ENV["SKIP_TEST_DATABASE_TRUNCATE"]` flag to speed up multi-process test runs on large DBs when all tests run within default transaction.
                                                                                                                                                 ^
activerecord/CHANGELOG.md:293 Trailing whitespace detected.

^^^^
activesupport/CHANGELOG.md:107 Trailing whitespace detected.

^^^^
railties/CHANGELOG.md:3 Trailing whitespace detected.

^^^^
railties/CHANGELOG.md:253 Trailing whitespace detected.

^^^^
13 changelogs inspected, 6 offenses detected

@zzak
Copy link
Member Author

zzak commented May 18, 2024

rubocop job fails due to #51857

@yahonda yahonda merged commit f31b853 into rails:7-2-stable May 18, 2024
2 of 3 checks passed
@zzak zzak deleted the 7-2-fix-changelog branch May 18, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants