Restore unused block warnings condition for Ruby 3.4 #51856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruby/ruby#10403 raised many "the block passed to" warnings. then idnored these warnings because some of them might have contain false positives. Now we can restore the warning condition because these false positives should have been addressed by these changes: ruby/ruby#10559 rails#51597 rails#51583
yahonda
force-pushed
the
restore_warning_condition_for_ruby34
branch
from
0cb195c
to
cba2b2f
Compare
rafaelfranca
pushed a commit
that referenced
this pull request
May 21, 2024
…ruby34 Restore unused block warnings condition for Ruby 3.4
|
I had overlooked Active Job integration test warnings. |
|
Opened an issue with repro. #51926 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This pull request restores the warning conditions not to ignore "the block passed to" warnings
Detail
ruby/ruby#10403 raised many "the block passed to" warnings. then idnored these warnings because some of them might have contain false positives.
Now we can restore the warning condition because these false positives should have been addressed by these changes:
ruby/ruby#10559
#51597
#51583
Additional information
None
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]