Look up route from requirements #51850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Rafael Mendonça França <[email protected]>
Co-authored-by: Rafael Mendonça França <[email protected]>
Co-authored-by: Rafael Mendonça França <[email protected]>
Co-authored-by: Rafael Mendonça França <[email protected]>
andyw8
changed the title
rafaelfranca
added a commit
that referenced
this pull request
May 23, 2024
* Lookup route from requirements * Add docs * Strings instead of symbols S * Update actionpack/lib/action_dispatch/routing/route_set.rb Co-authored-by: Rafael Mendonça França <[email protected]> * Update actionpack/lib/action_dispatch/routing/route_set.rb Co-authored-by: Rafael Mendonça França <[email protected]> * Update actionpack/lib/action_dispatch/routing/route_set.rb Co-authored-by: Rafael Mendonça França <[email protected]> * Update actionpack/lib/action_dispatch/routing/route_set.rb Co-authored-by: Rafael Mendonça França <[email protected]> --------- Co-authored-by: Andy Waite <[email protected]> Co-authored-by: Rafael Mendonça França <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
For Ruby LSP Rails, we are looking to add a Code Lens for controller actions which displays the corresponding path:
Shopify/ruby-lsp-rails#241
It is working, but calls into
RouteSetwhich is marked as private/internal.Detail
This adds a small
from_requirementsmethod as part of the public API, that can be used by editor tooling to determine the route corresponding to a given requirements hash.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]