Enable Style/CommandLiteral cop
#51741
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
PR rails#49624 contained commit 0c76f17 which mistakenly used backticks instead of normal string quotes. This is easy to miss, but risks introducing a security vulnerability into the codebase. Forcing the use of `%x()` should make it more obvious visually where the command literals are. See related rails#51739
flavorjones
force-pushed
the
flavorjones-rubocop-percent-x-command-literals
branch
from
9b952c8
to
6db0887
Compare
akhilgkrishnan
approved these changes
May 9, 2024
|
I appreciate wanting to guard against something like this, but aesthetically, I find the move from backticks to %x() to be a big regression. And I don't think it's worth scarring on the first cut here. I can't recall a single instance of the same issue going back two decades. So I think we need to see it repeated at least once before we contemplate an uglier code base as a result. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
PR #49624 contained commit 0c76f17 which mistakenly used backticks instead of normal string quotes. This is easy to miss, but is a bug-without-test-failures at best and an opportunity for an attack vector at worst.
Forcing the use of
%x()should make it more obvious visually where the command literals are.See related #51739
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]Tests are added or updated if you fix a bug or add a feature.CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.